* [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths
@ 2026-09-05 10:46 Karl Mehltretter
2026-09-05 19:29 ` Randy Dunlap
2026-11-19 8:22 ` Steffen Klassert
0 siblings, 2 replies; 3+ messages in thread
From: Karl Mehltretter @ 2026-09-05 10:46 UTC (permalink / raw)
To: Steffen Klassert, Herbert Xu
Cc: Karl Mehltretter, netdev, Jonathan Corbet, linux-doc, Shuah Khan,
Randy Dunlap
The sysctls are registered as xfrm_aevent_etime and xfrm_aevent_rseqth
under net.core (net/xfrm/xfrm_sysctl.c). The document calls them
sysctl_xfrm_aevent_etime and sysctl_xfrm_aevent_rseqth; those names
appear nowhere in the code but in a comment in net/xfrm/xfrm_user.c and
were never the proc file names.
Use the proc file names.
Fixes: b8a99520f78e ("[XFRM]: Add documentation for async events.")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Documentation/networking/xfrm/xfrm_sync.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/xfrm/xfrm_sync.rst b/Documentation/networking/xfrm/xfrm_sync.rst
index dfc2ec0df380..27e3d151b11e 100644
--- a/Documentation/networking/xfrm/xfrm_sync.rst
+++ b/Documentation/networking/xfrm/xfrm_sync.rst
@@ -120,12 +120,12 @@ in case they are not specified.
the two sysctls/proc entries are:
-a) /proc/sys/net/core/sysctl_xfrm_aevent_etime
+a) /proc/sys/net/core/xfrm_aevent_etime
Used to provide default values for the XFRMA_ETIMER_THRESH in incremental
units of time of 100ms. The default is 10 (1 second)
-b) /proc/sys/net/core/sysctl_xfrm_aevent_rseqth
+b) /proc/sys/net/core/xfrm_aevent_rseqth
Used to provide default values for XFRMA_REPLAY_THRESH parameter
in incremental packet count. The default is two packets.
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths
2026-09-05 10:46 [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths Karl Mehltretter
@ 2026-09-05 19:29 ` Randy Dunlap
2026-11-19 8:22 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-09-05 19:29 UTC (permalink / raw)
To: Karl Mehltretter, Steffen Klassert, Herbert Xu
Cc: netdev, Jonathan Corbet, linux-doc, Shuah Khan
On 9/5/26 3:46 AM, Karl Mehltretter wrote:
> The sysctls are registered as xfrm_aevent_etime and xfrm_aevent_rseqth
> under net.core (net/xfrm/xfrm_sysctl.c). The document calls them
> sysctl_xfrm_aevent_etime and sysctl_xfrm_aevent_rseqth; those names
> appear nowhere in the code but in a comment in net/xfrm/xfrm_user.c and
> were never the proc file names.
>
> Use the proc file names.
>
> Fixes: b8a99520f78e ("[XFRM]: Add documentation for async events.")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
> ---
> Documentation/networking/xfrm/xfrm_sync.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/xfrm/xfrm_sync.rst b/Documentation/networking/xfrm/xfrm_sync.rst
> index dfc2ec0df380..27e3d151b11e 100644
> --- a/Documentation/networking/xfrm/xfrm_sync.rst
> +++ b/Documentation/networking/xfrm/xfrm_sync.rst
> @@ -120,12 +120,12 @@ in case they are not specified.
>
> the two sysctls/proc entries are:
>
> -a) /proc/sys/net/core/sysctl_xfrm_aevent_etime
> +a) /proc/sys/net/core/xfrm_aevent_etime
>
> Used to provide default values for the XFRMA_ETIMER_THRESH in incremental
> units of time of 100ms. The default is 10 (1 second)
>
> -b) /proc/sys/net/core/sysctl_xfrm_aevent_rseqth
> +b) /proc/sys/net/core/xfrm_aevent_rseqth
>
> Used to provide default values for XFRMA_REPLAY_THRESH parameter
> in incremental packet count. The default is two packets.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths
2026-09-05 10:46 [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths Karl Mehltretter
2026-09-05 19:29 ` Randy Dunlap
@ 2026-11-19 8:22 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Steffen Klassert @ 2026-11-19 8:22 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Herbert Xu, netdev, Jonathan Corbet, linux-doc, Shuah Khan,
Randy Dunlap
On Sat, Sep 05, 2026 at 12:46:25PM +0200, Karl Mehltretter wrote:
> The sysctls are registered as xfrm_aevent_etime and xfrm_aevent_rseqth
> under net.core (net/xfrm/xfrm_sysctl.c). The document calls them
> sysctl_xfrm_aevent_etime and sysctl_xfrm_aevent_rseqth; those names
> appear nowhere in the code but in a comment in net/xfrm/xfrm_user.c and
> were never the proc file names.
>
> Use the proc file names.
>
> Fixes: b8a99520f78e ("[XFRM]: Add documentation for async events.")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Now applied to ipsec-next.
Thanks a lot and sorry for the delay!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 10:46 [PATCH ipsec-next] docs: xfrm: Fix the two aevent sysctl paths Karl Mehltretter
2026-09-05 19:29 ` Randy Dunlap
2026-11-19 8:22 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox