Re: [PATCH v2] Add config phase for dp83td510e phy

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 8 Sep 2026 10:08:43 +0000 Julien Blanc wrote:
> Add a config phase for the Texas Instruments DP83TD510E ethenet PHY
> 
> The config phase currently sets the following properties from the
> device tree:
>   * RMII / RGMII mode (note : RMII master / slave can only be set
>     by straps and cannot be changed at runtime)
>   * RGMII delays. These delays can be enabled on the phy side, only
>     as a boolean. Delays are enabled if phy-mode is rgmii-id, or
>     rgmii-[rx|tx]id which enables only the corresponding delay.

Clang says:

../drivers/net/phy/dp83td510.c:701:13: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  701 |         } else if (phydev->interface == PHY_INTERFACE_MODE_RMII) {
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/phy/dp83td510.c:710:9: note: uninitialized use occurs here
  710 |         return ret;
      |                ^~~
../drivers/net/phy/dp83td510.c:701:9: note: remove the 'if' if its condition is always true
  701 |         } else if (phydev->interface == PHY_INTERFACE_MODE_RMII) {
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/phy/dp83td510.c:675:9: note: initialize the variable 'ret' to silence this warning
  675 |         int ret;
      |                ^
      |                 = 0