[PATCH net-next] sit: do not report an error from ipip6_fill_info()

[PATCH net-next] sit: do not report an error from ipip6_fill_info()

[Eric Dumazet]

ipip6_fill_info() returns -ENODEV if tunnel->sit_parms is NULL.

This can not happen yet: sit_parms is only cleared from
ipip6_dev_free(), the priv_destructor, which runs long after
RTM_DELLINK has been built.

Returning an error from a fill_info() handler is still a trap,
because rtnl_dump_ifinfo() stops at the first failure and propagates
it, letting one device hide all the remaining ones.

Return 0 instead, there is nothing to report for a device that is
going away.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv6/sit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 14ba3cfb304a83ee37e3be5b09a57c371f1977c3..a7ec800216ade169985d389ad1dc672f0358f4ee 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -1853,9 +1853,10 @@ static int ipip6_fill_info(struct sk_buff *skb, const struct net_device *dev)
 
 	rcu_read_lock();
 	parm = rcu_dereference(tunnel->sit_parms);
+	/* If the device is being dismantled, there is nothing to report. */
 	if (!parm) {
 		rcu_read_unlock();
-		return -ENODEV;
+		return 0;
 	}
 
 	if (nla_put_u32(skb, IFLA_IPTUN_LINK, parm->link) ||
-- 
2.55.0.1007.g17ff1f9808-goog

Re: [PATCH net-next] sit: do not report an error from ipip6_fill_info()

[luoxuanqiang]

在 2026/9/12 08:54, Eric Dumazet 写道:
> ipip6_fill_info() returns -ENODEV if tunnel->sit_parms is NULL.
> 
> This can not happen yet: sit_parms is only cleared from
> ipip6_dev_free(), the priv_destructor, which runs long after
> RTM_DELLINK has been built.
> 
> Returning an error from a fill_info() handler is still a trap,
> because rtnl_dump_ifinfo() stops at the first failure and propagates
> it, letting one device hide all the remaining ones.
> 
> Return 0 instead, there is nothing to report for a device that is
> going away.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>

Thanks,
Xuanqiang

Re: [PATCH net-next] sit: do not report an error from ipip6_fill_info()

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

> ipip6_fill_info() returns -ENODEV if tunnel->sit_parms is NULL.
> 
> This can not happen yet: sit_parms is only cleared from
> ipip6_dev_free(), the priv_destructor, which runs long after
> RTM_DELLINK has been built.
> 
> Returning an error from a fill_info() handler is still a trap,
> because rtnl_dump_ifinfo() stops at the first failure and propagates
> it, letting one device hide all the remaining ones.
> 
> Return 0 instead, there is nothing to report for a device that is
> going away.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Acked-by: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>

> ---
>  net/ipv6/sit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index 14ba3cfb304a83ee37e3be5b09a57c371f1977c3..a7ec800216ade169985d389ad1dc672f0358f4ee 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1853,9 +1853,10 @@ static int ipip6_fill_info(struct sk_buff *skb, const struct net_device *dev)
>  
>  	rcu_read_lock();
>  	parm = rcu_dereference(tunnel->sit_parms);
> +	/* If the device is being dismantled, there is nothing to report. */
>  	if (!parm) {
>  		rcu_read_unlock();
> -		return -ENODEV;
> +		return 0;
>  	}
>  
>  	if (nla_put_u32(skb, IFLA_IPTUN_LINK, parm->link) ||
> -- 
> 2.55.0.1007.g17ff1f9808-goog
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]