From: Jakub Kicinski <kuba@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Michael Grzeschik" <mgr@kernel.org>,
"Denis Benato" <benato.denis96@gmail.com>,
netdev@vger.kernel.org, "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Aleksandr Loktionov" <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH] net: fealnx: remove never-true 486 CPU check
Date: Tue, 15 Sep 2026 15:51:09 -0700 [thread overview]
Message-ID: <20260915155109.068c222d@kernel.org> (raw)
In-Reply-To: <CADkSEUg2mgF6mB12uRi5605Mb0MTN=R5GF5FyrOcuyNVTc5H9w@mail.gmail.com>
On Mon, 14 Sep 2026 20:36:45 -0700 Ethan Nelson-Moore wrote:
> On Mon, Sep 14, 2026 at 7:46 PM Ethan Nelson-Moore
> <enelsonmoore@gmail.com> wrote:
> > The fealnx driver contains a check for boot_cpu_data.x86 <= 4.
> > This field encodes the x86 generation (3 = 386, 4 = 486, etc).
> > Therefore, since 486 support was removed from the kernel in commit
> > 8b793a92d862 ("x86/cpu: Remove M486/M486SX/ELAN support"), the
> > condition is always true. Remove the check.
>
> Oops, never true*. Should I send a v2, or will whoever merges this fix it?
Will fix
next prev parent reply other threads:[~2026-09-15 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:46 [PATCH] net: fealnx: remove never-true 486 CPU check Ethan Nelson-Moore
2026-09-15 3:36 ` Ethan Nelson-Moore
2026-09-15 22:51 ` Jakub Kicinski [this message]
2026-09-15 5:42 ` Loktionov, Aleksandr
2026-09-16 5:48 ` netdev-bot+sashiko
2026-09-17 2:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915155109.068c222d@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=arend.vanspriel@broadcom.com \
--cc=benato.denis96@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=mgr@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaojijie@huawei.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox