From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: enelsonmoore@gmail.com, u.kleine-koenig@baylibre.com,
arend.vanspriel@broadcom.com, johannes@sipsolutions.net,
mgr@kernel.org, benato.denis96@gmail.com, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shaojijie@huawei.com,
aleksandr.loktionov@intel.com
Subject: Re: [PATCH] net: fealnx: remove never-true 486 CPU check
Date: Wed, 16 Sep 2026 19:22:41 -0700 [thread overview]
Message-ID: <20260916192241.320ea5e0@kernel.org> (raw)
In-Reply-To: <178953770825.22033.17119468095020104751@kernel.org>
On Wed, 16 Sep 2026 05:48:28 +0000 netdev-bot+sashiko@kernel.org wrote:
> > -#if defined(__i386__) && !defined(MODULE) && !defined(CONFIG_UML)
> > - if (boot_cpu_data.x86 <= 4)
> > - np->crvalue = 0xa00;
> > - else
> > -#endif
> > - np->crvalue = 0xe00; /* rx 128 burst length */
> > + np->crvalue = 0xe00; /* rx 128 burst length */
>
> [Severity: Low]
> This removes the last user of asm/processor.h in the file, but the include and
> its justification comment near the top of drivers/net/ethernet/fealnx.c are
> left behind:
>
> #include <asm/processor.h> /* Processor type for cache alignment. */
>
> After this patch, git grep boot_cpu_data on the file returns nothing, and a
> grep for other plausible users (cpu_relax, cpu_data, cache_line*) also finds
> nothing. Should the include be dropped together with its only user?
Massaging the comment is more a judgment call (the other Low complaint
from AI) but the header we should probably remove..
prev parent reply other threads:[~2026-09-17 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:46 [PATCH] net: fealnx: remove never-true 486 CPU check Ethan Nelson-Moore
2026-09-15 3:36 ` Ethan Nelson-Moore
2026-09-15 22:51 ` Jakub Kicinski
2026-09-15 5:42 ` Loktionov, Aleksandr
2026-09-16 5:48 ` netdev-bot+sashiko
2026-09-17 2:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916192241.320ea5e0@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=arend.vanspriel@broadcom.com \
--cc=benato.denis96@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=mgr@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaojijie@huawei.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox