From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Sheena Mohan <sheenamo@google.com>,
Willem de Bruijn <willemb@google.com>,
Adrian Pielech <adrian.pielech@intel.com>,
Przemyslaw Kitszel <przemyslaw.kitszel@intel.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
bjorn@kernel.org, maciej.fijalkowski@intel.com
Subject: Re: [RFC net-next 0/6] selftests: net: add performance metric reporting
Date: Thu, 17 Sep 2026 13:01:37 -0700 [thread overview]
Message-ID: <20260917130137.2fa3b9d9@kernel.org> (raw)
In-Reply-To: <20260916190409.1222272-1-sdf@fomichev.me>
Adding Sheena, Willem, Przemek, and Adrian, who I have in my notes
as folks responsible for the Google and Intel NIPA runners.
(Please LMK if I should update my notes!)
On Wed, 16 Sep 2026 12:04:03 -0700 Stanislav Fomichev wrote:
> Sharing as an RFC to get the feedback on the overall approach. Current
> model is where the ktap side drives system monitoring and nipa only
> collects/interprets/draws. Another way we can do it is to move system
> monitoring stuff to nipa.
>
> ktap-side monitoring pros/cons:
> - pro: same format for system vs test metrics (same parser, same
> aggregator, etc)
> - pro: test controls when the system collection starts
> - pro: test controls what the system collects (say, on multi-nic
> machines, we collect only the things that matter)
> - pro: local runs produce the same output (and we can add some tools to
> produce the aggregates for local analysis)
I'm CCing folks from other runners, because I wonder how much it would
help them. I don't think lifting the code form NIPA would be a major
effort, with LLMs. But it is work..
> - con: bespoke metrics aggregation format defined/exported by the test (but
> I think we still need it for non-system metrics regardless?)
> - con: extra code/complexity on ksft side (although it's only SystemMonitor,
> the rest of this patch series still relevant)
That's a big one for me, hand up who is able to read all netdev@
traffic as is, this will be more emails and review :(
> nipa-side monitoring pros/cons:
> - pro: more code stays on nipa side
yes, which aligns with where runners are and we can fix things much
more quickly
> - pro: tests don't care about system side of things, it's always
> collected on nipa side
> - pro: each nipa runner can define its own policy/thresholds (although,
> why would we want it only for the system side and not the test side?)
pro: the system metrics require no semantic annotations for the UI,
since NIPA produces them it knows them
> - con: separate collection & parsing (system vs test)
> - con: local runs need nipa if we want to observe the metrics
On the code organization - should we not keep the perf tests
separate?
- the perf tests will probably need to run ~30 sec each
and it's very easy to multiply the variants. I'm worried
we may need to sooner or later split them out and only run
a portion of the tests for each branch if they take long?
- makes no sense to run perf tests for debug kernels.
- extra infra and history is required to make sense of results,
no point running them during 95% of development..
That's my $.50, I don't love the ksft.py changes, but I'm open
to trying if others think this is the right move. So please share
your opinions? :S
prev parent reply other threads:[~2026-09-17 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 19:04 [RFC net-next 0/6] selftests: net: add performance metric reporting Stanislav Fomichev
2026-09-16 19:04 ` [RFC net-next 1/6] selftests: net: py: add timestamped metric output Stanislav Fomichev
2026-09-22 16:10 ` Paolo Abeni
2026-09-16 19:04 ` [RFC net-next 2/6] selftests: net: py: add metric policy output Stanislav Fomichev
2026-09-22 16:16 ` Paolo Abeni
2026-09-16 19:04 ` [RFC net-next 3/6] selftests: drv-net: add a system performance monitor Stanislav Fomichev
2026-09-16 19:04 ` [RFC net-next 4/6] selftests: drv-net: add an iperf performance test Stanislav Fomichev
2026-09-16 19:04 ` [RFC net-next 5/6] selftests: drv-net: add a kperf runner Stanislav Fomichev
2026-09-16 19:04 ` [RFC net-next 6/6] selftests: drv-net: measure devmem performance with kperf Stanislav Fomichev
2026-09-17 20:01 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917130137.2fa3b9d9@kernel.org \
--to=kuba@kernel.org \
--cc=adrian.pielech@intel.com \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf.kernel@gmail.com \
--cc=sheenamo@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox