Re: [RFC net-next 1/6] selftests: net: py: add timestamped metric output

[Paolo Abeni <pabeni@redhat.com>]

On 9/16/26 21:04, Stanislav Fomichev wrote:
> Add ksft_metric() to record timestamped JSON observations for the current
> test case.
> 
> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
> ---
>   .../testing/selftests/drivers/net/README.rst  | 27 ++++++++++++
>   .../drivers/net/hw/lib/py/__init__.py         |  8 ++--
>   .../selftests/drivers/net/lib/py/__init__.py  |  8 ++--
>   .../testing/selftests/net/lib/py/__init__.py  |  9 ++--
>   tools/testing/selftests/net/lib/py/ksft.py    | 44 ++++++++++++++++++-
>   5 files changed, 83 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/README.rst b/tools/testing/selftests/drivers/net/README.rst
> index 3fe49bce4f3a..a6a8605844eb 100644
> --- a/tools/testing/selftests/drivers/net/README.rst
> +++ b/tools/testing/selftests/drivers/net/README.rst
> @@ -259,6 +259,33 @@ ksft_pr()
>   
>   Use ``ksft_pr()`` instead of ``print()`` to avoid breaking TAP format.
>   
> +ksft_metric()
> +~~~~~~~~~~~~~
> +
> +Use ``ksft_metric()`` to report a numeric measurement for the current test
> +case. The helper records the time relative to the start of the case and emits
> +each observation immediately before the test result as compact JSON. For
> +example::
> +
> +  ksft_metric("throughput", 100.5, shape="scalar", direction="rx")

Minor nits:
- find the 'shape' name confusing/unclear. I would like more 'type' instead.
   also it would ne nice to list explicitly somewhere in the doc the suppored
   shapes/types. (If such list is already there I could not find it easily).
- do we need a separare 'direction'? or can it be embedded into the name
   metric itself? i.e. 'throughput-rx'?

/P