* [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink().
@ 2026-09-16 23:09 Kuniyuki Iwashima
2026-09-17 3:25 ` Xuanqiang Luo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kuniyuki Iwashima @ 2026-09-16 23:09 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
David Ahern, Ido Schimmel
Cc: Simon Horman, William Tu, Kuniyuki Iwashima, Kuniyuki Iwashima,
netdev
The cited commit accidentally added ip6gre_tunnel_unlink_md()
in ip6erspan_changelink().
Let's correct it to ip6erspan_tunnel_unlink_md().
Fixes: b80d0b93b991 ("net: ip6_gre: fix tunnel metadata device sharing.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
---
net/ipv6/ip6_gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 8ebda0b6a78b..e61cb10b50dc 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -2279,7 +2279,7 @@ static int ip6erspan_changelink(struct net_device *dev, struct nlattr *tb[],
return PTR_ERR(t);
ip6erspan_set_version(data, &p);
- ip6gre_tunnel_unlink_md(ign, t);
+ ip6erspan_tunnel_unlink_md(ign, t);
ip6gre_tunnel_unlink(ign, t);
ip6erspan_tnl_change(t, &p, !tb[IFLA_MTU]);
ip6erspan_tunnel_link_md(ign, t);
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink().
2026-09-16 23:09 [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink() Kuniyuki Iwashima
@ 2026-09-17 3:25 ` Xuanqiang Luo
2026-09-17 16:16 ` Ido Schimmel
2026-09-19 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Xuanqiang Luo @ 2026-09-17 3:25 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: Simon Horman, William Tu, Kuniyuki Iwashima, netdev,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
David Ahern, Ido Schimmel
在 2026/9/17 07:09, Kuniyuki Iwashima 写道:
> The cited commit accidentally added ip6gre_tunnel_unlink_md()
> in ip6erspan_changelink().
>
> Let's correct it to ip6erspan_tunnel_unlink_md().
>
> Fixes: b80d0b93b991 ("net: ip6_gre: fix tunnel metadata device sharing.")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> ---
Reviewed-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink().
2026-09-16 23:09 [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink() Kuniyuki Iwashima
2026-09-17 3:25 ` Xuanqiang Luo
@ 2026-09-17 16:16 ` Ido Schimmel
2026-09-19 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Ido Schimmel @ 2026-09-17 16:16 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
David Ahern, Simon Horman, William Tu, Kuniyuki Iwashima, netdev
On Wed, Sep 16, 2026 at 11:09:24PM +0000, Kuniyuki Iwashima wrote:
> The cited commit accidentally added ip6gre_tunnel_unlink_md()
> in ip6erspan_changelink().
>
> Let's correct it to ip6erspan_tunnel_unlink_md().
>
> Fixes: b80d0b93b991 ("net: ip6_gre: fix tunnel metadata device sharing.")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink().
2026-09-16 23:09 [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink() Kuniyuki Iwashima
2026-09-17 3:25 ` Xuanqiang Luo
2026-09-17 16:16 ` Ido Schimmel
@ 2026-09-19 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-19 0:10 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: davem, edumazet, kuba, pabeni, dsahern, idosch, horms, u9012063,
kuni1840, netdev
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Sep 2026 23:09:24 +0000 you wrote:
> The cited commit accidentally added ip6gre_tunnel_unlink_md()
> in ip6erspan_changelink().
>
> Let's correct it to ip6erspan_tunnel_unlink_md().
>
> Fixes: b80d0b93b991 ("net: ip6_gre: fix tunnel metadata device sharing.")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
>
> [...]
Here is the summary with links:
- [v1,net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink().
https://git.kernel.org/netdev/net/c/dd47bcf279f1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-19 0:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16 23:09 [PATCH v1 net] ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink() Kuniyuki Iwashima
2026-09-17 3:25 ` Xuanqiang Luo
2026-09-17 16:16 ` Ido Schimmel
2026-09-19 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox