From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Chintan Vankar <c-vankar@ti.com>,
Danish Anwar <danishanwar@ti.com>, Daolin Qiu <d-qiu@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Felix Maurer <fmaurer@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Neelima Muralidharan <neelima@ti.com>,
Paolo Abeni <pabeni@redhat.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Pratheesh Gangadhar TK <pratheesh@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH net-next v5 2/8] hsr: Use skb_clone() while adding the HSR header
Date: Fri, 18 Sep 2026 17:43:58 +0200 [thread overview]
Message-ID: <20260918154358.bTSERqD6@linutronix.de> (raw)
In-Reply-To: <willemdebruijn.kernel.92aa2ef1162@gmail.com>
On 2026-05-29 15:55:45 [-0400], Willem de Bruijn wrote:
> Sebastian Andrzej Siewior wrote:
> > hsr_create_tagged_frame() creates a new skb where the HSR header can be
> > prepended via __pskb_copy(). This does not copy the skb_shared_info part
> > of the original skb so any timestamp request is lost.
> >
> > An alternative is to use skb_clone() where the skb_shared_info part is
> > copied and then skb_cow_head() to make the header part writeable. This
>
> small nit: the shared info is not copied, clones share the same struct.
updated, thank you.
Sebastian
next prev parent reply other threads:[~2026-09-18 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 15:08 [PATCH net-next v5 0/8] hsr: Add additional info to send/ receive skbs Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 1/8] hsr: Add header_ops::parse_protocol Sebastian Andrzej Siewior
2026-05-29 19:53 ` Willem de Bruijn
2026-09-18 15:42 ` Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 2/8] hsr: Use skb_clone() while adding the HSR header Sebastian Andrzej Siewior
2026-05-29 19:55 ` Willem de Bruijn
2026-09-18 15:43 ` Sebastian Andrzej Siewior [this message]
2026-05-27 15:08 ` [PATCH net-next v5 3/8] hsr: Add a magic header for sending PTP packets Sebastian Andrzej Siewior
2026-05-29 19:58 ` Willem de Bruijn
2026-09-18 16:30 ` Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 4/8] hsr: Drop received " Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 5/8] hsr: Use the port and header information in hsr_forward_skb() Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 6/8] hsr: Assign a socket for cloned skbs Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 7/8] hsr: Move struct hsr_ethhdr to a global header Sebastian Andrzej Siewior
2026-05-27 15:08 ` [PATCH net-next v5 8/8] selftests: hsr: Add test for the inline PTP header on HSR Sebastian Andrzej Siewior
2026-05-27 19:12 ` Jakub Kicinski
2026-05-28 6:27 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918154358.bTSERqD6@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=c-vankar@ti.com \
--cc=d-qiu@ti.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=neelima@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=vigneshr@ti.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox