Re: [PATCH net v6] net: Wangxun: protect ring accesses with RCU

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 15 Sep 2026 14:57:31 +0800 Mengyuan Lou wrote:
> -			wx->tx_ring[i]->count = new_tx_count;
> +			rcu_dereference_protected(wx->tx_ring[i],
> +						  lockdep_is_held(&wx->reset_lock))->count =
> +				new_tx_count;

Do you really think this is acceptable code formatting?

Plus I quite clearly asked you to add a helper:
https://lore.kernel.org/all/20260915184127.25de623e@kernel.org/

> @@ -1797,7 +1801,8 @@ static void wx_set_rx_buffer_len(struct wx *wx)
>  	 * the Base and Length of the Rx Descriptor Ring
>  	 */
>  	for (i = 0; i < wx->num_rx_queues; i++) {
> -		rx_ring = wx->rx_ring[i];
> +		rx_ring = rcu_dereference_protected(wx->rx_ring[i],
> +						    lockdep_rtnl_is_held());

And also to use:

/**
 * rtnl_dereference - fetch RCU pointer when updates are prevented by RTNL
 * @p: The pointer to read, prior to dereferencing
 *
 * Return: the value of the specified RCU-protected pointer, but omit
 * the READ_ONCE(), because caller holds RTNL.
 */
#define rtnl_dereference(p)					\
	rcu_dereference_protected(p, lockdep_rtnl_is_held())

Please, this is not rocket science. Pay more attention to what you're doing,
this sort of change should not require 10 revisions.
-- 
pw-bot: cr