From: Jakub Kicinski <kuba@kernel.org>
To: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com,
duanqiangwen@net-swift.com, linglingzhang@net-swift.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jacob.e.keller@intel.com,
richardcochran@gmail.com
Subject: Re: [PATCH net v6] net: Wangxun: protect ring accesses with RCU
Date: Tue, 22 Sep 2026 17:19:44 -0700 [thread overview]
Message-ID: <20260922171944.6ba2da64@kernel.org> (raw)
In-Reply-To: <BE54C737-C413-4A44-A27B-55040D41B1FD@net-swift.com>
On Tue, 22 Sep 2026 16:48:16 +0800 mengyuanlou@net-swift.com wrote:
> Sorry about that. I’ll fix both issues in the next revision and make sure to
> address the previous review comments more carefully.
> Thanks.
>
> Another question:
>
> wx_init_interrupt_scheme() →
> wx_lib.c:2392 wx_cache_ring_rss() →
> wx_lib.c: rcu_dereference_protected(..., lockdep_rtnl_is_held())
>
> When wx_init_interrupt_scheme is in xxx_probe, unlike other txgbe_setup_tc
> and ngbe_resume, at this point the netdev has not yet been registered.
>
> +rtnl_lock();
> err = wx_init_interrupt_scheme(wx);
> +rtnl_unlock();
> if (err)
> goto err_cancel_service;
>
> At this point, rntl_lock is merely used to address RCU_LOCKDEP_WARN.
> Is this approach appropriate?
I think that's acceptable. Maybe add a comment as well just to make it
clear why we're taking the lock.
prev parent reply other threads:[~2026-09-23 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:57 [PATCH net v6] net: Wangxun: protect ring accesses with RCU Mengyuan Lou
2026-09-19 7:16 ` netdev-bot+sashiko
2026-09-22 0:05 ` Jakub Kicinski
2026-09-22 8:48 ` mengyuanlou
2026-09-23 0:19 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922171944.6ba2da64@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=linglingzhang@net-swift.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox