From: Karl Mehltretter <kmehltretter@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
stable@vger.kernel.org, patches@lists.linux.dev,
Nicolai Buchwitz <nb@tipi-net.de>,
Justin Chen <justin.chen@broadcom.com>,
Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.18 129/398] net: bcmgenet: convert RX path to page_pool
Date: Thu, 24 Sep 2026 08:58:39 +0200 [thread overview]
Message-ID: <20260924065839.56793-1-kmehltretter@gmail.com> (raw)
In-Reply-To: <20260923140646.783275824@linuxfoundation.org>
I have a small objection to taking patch 129 into 6.18.y only as a
dependency for patch 130.
My LLM agent helped me running these tests.
On a 64 KiB arm64 kernel in a custom QEMU Pi 400 model with functional
GENET v5 DMA, patch 129 increased the socket receive-memory charge per
512-byte UDP datagram from 2,752 to 65,792 bytes.
With the same 512 KiB socket receive-buffer limit, this reduced the number
of queued datagrams from 190 to 7 and increased socket receive-buffer drops
from 810 to 993 per 1,000 datagrams. I obtained the same result in five
bursts.
The page-pool conversion otherwise worked in this test, and physical Pi 400
testing with 4 KiB pages found no correctness failure. However, patch 130
was also verified on the Pi 400 to work without patch 129 after a small
contextual adaptation.
I would appreciate the BCMGENET maintainers' view on whether this page-pool
conversion is appropriate for 6.18.y.
Please consider omitting patch 129 from 6.18.y and applying that adapted
version of patch 130 directly.
Full test details and logs are available if useful.
Thanks,
Karl
next parent reply other threads:[~2026-09-24 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260923140643.441954610@linuxfoundation.org>
[not found] ` <20260923140646.783275824@linuxfoundation.org>
2026-09-24 6:58 ` Karl Mehltretter [this message]
2026-09-24 7:28 ` [PATCH 6.18 129/398] net: bcmgenet: convert RX path to page_pool Greg Kroah-Hartman
2026-09-24 8:10 ` Nicolai Buchwitz
2026-09-24 10:36 ` Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924065839.56793-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox