From: Nicolai Buchwitz <nb@tipi-net.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
stable@vger.kernel.org, patches@lists.linux.dev,
Justin Chen <justin.chen@broadcom.com>,
Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.18 129/398] net: bcmgenet: convert RX path to page_pool
Date: Thu, 24 Sep 2026 12:36:23 +0200 [thread overview]
Message-ID: <222228376db00a8aa7a4bcab1b5659bc@tipi-net.de> (raw)
In-Reply-To: <2026092430-contently-pungent-f0cc@gregkh>
Hi Greg, hi Karl
On 24.9.2026 09:28, Greg Kroah-Hartman wrote:
> On Thu, Sep 24, 2026 at 08:58:39AM +0200, Karl Mehltretter wrote:
> [...]
>> I would appreciate the BCMGENET maintainers' view on whether this
>> page-pool
>> conversion is appropriate for 6.18.y.
I would rather have the page_pool conversion in 6.18.y. More fixes will
land on top of it, and carrying it is less work than adapting each of
them. The fix for the regression applies on top of it unchanged.
>> Please consider omitting patch 129 from 6.18.y and applying that
>> adapted
>> version of patch 130 directly.
>
> But when you update to a newer release, that memory increase will
> happen, right? So why not fix the root problem upstream first?
The fix is on netdev, "net: bcmgenet: allocate RX buffers as page
fragments", with a Fixes tag for 7bc054c2d4ed:
https://lore.kernel.org/netdev/20260924101922.2675127-1-nb@tipi-net.de
I was able to reproduce Karl's numbers on a CM4 with a 64 KiB page
kernel
and fortunately the fix was straightforward.
> [...]
Regards
Nicolai
prev parent reply other threads:[~2026-09-24 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260923140643.441954610@linuxfoundation.org>
[not found] ` <20260923140646.783275824@linuxfoundation.org>
2026-09-24 6:58 ` [PATCH 6.18 129/398] net: bcmgenet: convert RX path to page_pool Karl Mehltretter
2026-09-24 7:28 ` Greg Kroah-Hartman
2026-09-24 8:10 ` Nicolai Buchwitz
2026-09-24 10:36 ` Nicolai Buchwitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=222228376db00a8aa7a4bcab1b5659bc@tipi-net.de \
--to=nb@tipi-net.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=justin.chen@broadcom.com \
--cc=kmehltretter@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox