From: Robert Marko <robert.marko@sartura.hr>
To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, hkallweit1@gmail.com,
lxu@maxlinear.com, michael@walle.cc, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: luka.perkov@sartura.hr, Robert Marko <robert.marko@sartura.hr>
Subject: [PATCH 3/5] net: phy: mxl-gpy: release MxL86211C Super Isolate
Date: Wed, 30 Sep 2026 14:22:15 +0200 [thread overview]
Message-ID: <20260930122305.293686-3-robert.marko@sartura.hr> (raw)
In-Reply-To: <20260930122305.293686-1-robert.marko@sartura.hr>
The MxL86211C can be strapped into Super Isolate mode, leaving
the PHY halted after reset until software releases it.
Clear VSPEC1_PM_CTRL.SI after registering the MDIO voltage regulator
and before the generic GPY initialization accesses the PHY.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
drivers/net/phy/mxl-gpy.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 4cbbfae046317..790075632fc3f 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -115,6 +115,7 @@
/* Packet Manager Control */
#define VSPEC1_PM_CTRL 0x0c
#define VSPEC1_PM_CTRL_MDIO_VOL BIT(14)
+#define VSPEC1_PM_CTRL_SI BIT(12) /* Super Isolate */
/* Temperature sensor */
#define VSPEC1_TEMP_STA 0x0E
@@ -446,10 +447,6 @@ static int mxl86211c_probe(struct phy_device *phydev)
struct regulator_dev *rdev;
int ret;
- ret = gpy_probe(phydev);
- if (ret)
- return ret;
-
config.dev = dev;
config.driver_data = phydev;
@@ -459,7 +456,15 @@ static int mxl86211c_probe(struct phy_device *phydev)
return PTR_ERR(rdev);
}
- return 0;
+ ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1, VSPEC1_PM_CTRL,
+ VSPEC1_PM_CTRL_SI,
+ 0);
+ if (ret)
+ return ret;
+
+ ret = gpy_probe(phydev);
+
+ return ret;
}
static bool gpy_sgmii_need_reaneg(struct phy_device *phydev)
--
2.55.0
next prev parent reply other threads:[~2026-09-30 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 12:22 [PATCH 1/5] dt-bindings: net: maxlinear: add MxL86211C MDIO I/O regulator Robert Marko
2026-09-30 12:22 ` [PATCH 2/5] net: phy: mxl-gpy: " Robert Marko
2026-10-04 13:17 ` netdev-bot+sashiko
2026-09-30 12:22 ` Robert Marko [this message]
2026-10-04 13:17 ` [PATCH 3/5] net: phy: mxl-gpy: release MxL86211C Super Isolate netdev-bot+sashiko
2026-09-30 12:22 ` [PATCH 4/5] dt-bindings: net: maxlinear: add MxL86211C lane mapping support Robert Marko
2026-10-01 5:55 ` Krzysztof Kozlowski
2026-10-01 12:14 ` Robert Marko
2026-10-01 12:33 ` Andrew Lunn
2026-10-07 8:49 ` Robert Marko
2026-10-07 13:14 ` Andrew Lunn
2026-10-01 16:25 ` Rob Herring (Arm)
2026-10-04 13:17 ` netdev-bot+sashiko
2026-09-30 12:22 ` [PATCH 5/5] net: phy: mxl-gpy: support MxL86211C lane mapping Robert Marko
2026-09-30 15:35 ` Andrew Lunn
2026-09-30 16:58 ` Robert Marko
2026-10-04 13:17 ` netdev-bot+sashiko
2026-10-04 13:17 ` [PATCH 1/5] dt-bindings: net: maxlinear: add MxL86211C MDIO I/O regulator netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930122305.293686-3-robert.marko@sartura.hr \
--to=robert.marko@sartura.hr \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=lxu@maxlinear.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox