Re: [PATCH net v2 0/9] bnxt_en: Bug fixes

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 1 Oct 2026 12:22:38 -0700 Michael Chan wrote:
> > This is an automated message. This series looks like a fix, but its
> > commit messages seem to be missing some information:
> >
> >  - How the issue was discovered, e.g. hit in production, hit during
> >    development, syzbot report, manual code inspection, LLM or static
> >    analysis tool scan.
> >
> >  - Whether the issue was actually triggered, or is only theoretical
> >    (e.g. found by code inspection). If it was triggered please include
> >    the symptoms, like the stack trace or error messages.  
> 
> The ring accounting bugs fixed by the 1st 6 patches were originally
> reported by Sashiko while posting the kTLS patches to net-next:
> 
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260810051358.1244418-7-michael.chan@broadcom.com
> 
> kTLS needs to use the new MPC rings, so the ring accounting logic is
> touched, exposing the issues to Sashiko.  These are pre-existing bugs
> that affect normal RX/TX rings when FW is running short on rings.  The
> issues are real, but not likely unless many VFs cause ring shortages.
> Patches 7, 8, 9 are real issues found in the lab or by partners.
> 
> >
> >  - What hardware the change was tested on. For driver fixes please
> >    mention the device (and if relevant firmware version) used for
> >    testing, or say that the change was not tested on real hardware.
> >  
> 
> The changes were regression tested on the 5760X and 5750X chips (the 2
> latest chip generations) using production FW (237.x.x.x).

Hm, someone set this to changes requested.

Can we split this series in two? Let's take the last 3 via net and the
AI-discovered, un-proven (meaning - I'm assuming you haven't actually
triggered the issue) 6 via net-next?

Hopefully Pavan can adjust the net patches according to the AI review
while at it, at least the suggestion to explicitly remember state on
patch 9 looks trivial, on a quick read?