Netdev List
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: idosch@nvidia.com, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	bridge@lists.linux.dev, Nikolay Aleksandrov <razor@blackwall.org>
Subject: [PATCH net-next 2/6] net: bridge: fdb: update the comment for br_fdb_cleanup_by_dst
Date: Mon,  5 Oct 2026 17:39:33 +0300	[thread overview]
Message-ID: <20261005143937.877466-3-razor@blackwall.org> (raw)
In-Reply-To: <20261005143937.877466-1-razor@blackwall.org>

Update the comment for br_fdb_cleanup_by_dst to better reflect what it is
doing after the recent changes.

Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
 net/bridge/br_fdb.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 730b178cf6c4..ce09e3fbc58b 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -868,9 +868,11 @@ int br_fdb_delete_bulk(struct nlmsghdr *nlh, struct net_device *dev,
 	return 0;
 }
 
-/* Clean up all entries referring to a specific destination.
- * if do_all is set also flush static entries
- * if vid is set delete all entries that match the vlan_id
+/* Clean up entries referring to cleanup_dst's port.
+ * If do_all is set ignore vid and entry flags. Otherwise vid selects
+ * the VLAN (0 means all), keeping static and non-offloaded ext learned entries.
+ * For a port-VLAN dst, vid must match its VLAN ID. Always clean up its local
+ * entry unless user-added and fall back to the port dst for retained entries.
  */
 void br_fdb_cleanup_by_dst(struct net_bridge *br,
 			   struct net_bridge_dst cleanup_dst, u16 vid,
-- 
2.47.3


  parent reply	other threads:[~2026-10-05 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 14:39 [PATCH net-next 0/6] net: bridge: fwd optimization cleanups Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 1/6] net: bridge: rename dst to fwd in br_flood_vlan Nikolay Aleksandrov
2026-10-05 14:39 ` Nikolay Aleksandrov [this message]
2026-10-05 14:39 ` [PATCH net-next 3/6] net: bridge: vlan: share VLAN validation in br_should_learn Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 4/6] net: bridge: vlan: inline pvid pointer updates Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 5/6] net: bridge: fdb: factor out configured entry destination updates Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 6/6] net: bridge: fdb: use the entry key in __fdb_update Nikolay Aleksandrov
2026-10-06 12:39 ` [PATCH net-next 0/6] net: bridge: fwd optimization cleanups Ido Schimmel
2026-10-07  1:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005143937.877466-3-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox