From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: idosch@nvidia.com, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
bridge@lists.linux.dev, Nikolay Aleksandrov <razor@blackwall.org>
Subject: [PATCH net-next 6/6] net: bridge: fdb: use the entry key in __fdb_update
Date: Mon, 5 Oct 2026 17:39:37 +0300 [thread overview]
Message-ID: <20261005143937.877466-7-razor@blackwall.org> (raw)
In-Reply-To: <20261005143937.877466-1-razor@blackwall.org>
The address and VLAN ID passed to __fdb_update() match the key of the entry
just found, so we can just use it.
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
net/bridge/br_fdb.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 927e5f23df5b..b601245ad923 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -1000,7 +1000,6 @@ static void __fdb_update(struct net_bridge *br,
struct net_bridge_fdb_entry *fdb,
struct net_bridge_port *source,
struct net_bridge_dst dst,
- const unsigned char *addr, u16 vid,
unsigned long flags)
{
struct net_bridge_port *old_port;
@@ -1012,7 +1011,8 @@ static void __fdb_update(struct net_bridge *br,
if (unlikely(test_bit(BR_FDB_LOCAL, &fdb->flags))) {
if (net_ratelimit())
br_warn(br, "received packet on %s with own address as source address (addr:%pM, vlan:%u)\n",
- source->dev->name, addr, vid);
+ source->dev->name, fdb->key.addr.addr,
+ fdb->key.vlan_id);
return;
}
@@ -1055,7 +1055,8 @@ static void __fdb_update(struct net_bridge *br,
}
if (unlikely(fdb_modified)) {
- trace_br_fdb_update(br, source, addr, vid, flags);
+ trace_br_fdb_update(br, source, fdb->key.addr.addr,
+ fdb->key.vlan_id, flags);
fdb_notify(br, fdb, RTM_NEWNEIGH, true);
}
}
@@ -1075,7 +1076,7 @@ void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
fdb = fdb_find_rcu(&br->fdb_hash_tbl, addr, vid);
if (likely(fdb)) {
- __fdb_update(br, fdb, source, dst, addr, vid, flags);
+ __fdb_update(br, fdb, source, dst, flags);
} else {
spin_lock(&br->hash_lock);
fdb = fdb_create(br, dst, addr, vid, flags);
--
2.47.3
next prev parent reply other threads:[~2026-10-05 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 14:39 [PATCH net-next 0/6] net: bridge: fwd optimization cleanups Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 1/6] net: bridge: rename dst to fwd in br_flood_vlan Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 2/6] net: bridge: fdb: update the comment for br_fdb_cleanup_by_dst Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 3/6] net: bridge: vlan: share VLAN validation in br_should_learn Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 4/6] net: bridge: vlan: inline pvid pointer updates Nikolay Aleksandrov
2026-10-05 14:39 ` [PATCH net-next 5/6] net: bridge: fdb: factor out configured entry destination updates Nikolay Aleksandrov
2026-10-05 14:39 ` Nikolay Aleksandrov [this message]
2026-10-06 12:39 ` [PATCH net-next 0/6] net: bridge: fwd optimization cleanups Ido Schimmel
2026-10-07 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005143937.877466-7-razor@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox