From: Daehyeon Ko <4ncienth@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: pablo@netfilter.org, fw@strlen.de, phil@nwl.cc,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, stable@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH v2 net] netfilter: conntrack: reject nested ctnetlink master chains
Date: Wed, 7 Oct 2026 10:33:01 +0900 [thread overview]
Message-ID: <20261007013301.2524415-1-4ncienth@gmail.com> (raw)
In-Reply-To: <179127347858.434549.11821822167265441355@kernel.org>
Thanks for the review. All three points are valid.
The nft ct expectation object can attach its internal helper to an
unconfirmed expected child, then arm the next expectation with that child
as master. I confirmed a bounded four-entry chain through this path, and
current net retains the same unchecked transition. An nft helper followed
by IPCTNL_MSG_EXP_NEW can repeat in the same way. The H.323 Q.931
call-forwarding path also propagates its helper without a depth bound.
The CT_NEW compatibility concern is valid as well. CTA_TUPLE_MASTER was
introduced for conntrackd replication, so rejecting nested helper-created
state changes that interface.
V2 is therefore incomplete and should not be applied. I have reworked the
replacement to make master destruction stack-safe while preserving nested
expectation semantics.
pw-bot: cr
prev parent reply other threads:[~2026-10-07 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 18:02 [PATCH net] netfilter: conntrack: avoid recursive master destruction Daehyeon Ko
2026-10-01 19:19 ` Florian Westphal
2026-10-02 5:39 ` Daehyeon Ko
2026-10-02 9:56 ` Pablo Neira Ayuso
2026-10-02 9:55 ` Pablo Neira Ayuso
2026-10-02 9:55 ` Pablo Neira Ayuso
2026-10-02 16:56 ` [PATCH v2 net] netfilter: conntrack: reject nested ctnetlink master chains Daehyeon Ko
2026-10-02 16:58 ` netdev-bot+sinfo
2026-10-02 17:35 ` Florian Westphal
2026-10-06 7:57 ` netdev-bot+sashiko
2026-10-07 1:33 ` Daehyeon Ko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007013301.2524415-1-4ncienth@gmail.com \
--to=4ncienth@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox