Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next] net: natsemi: xtsonic: make probe function static
@ 2026-10-08 18:30 Randy Dunlap
  2026-10-09  6:18 ` Björn Töpel
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-10-08 18:30 UTC (permalink / raw)
  To: netdev
  Cc: patches, Randy Dunlap, Thomas Bogendoerfer, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni

Avoid a build warning by making the probe function static:

drivers/net/ethernet/natsemi/xtsonic.c:200:5: warning: no previous prototype for 'xtsonic_probe' [-Wmissing-prototypes]
  200 | int xtsonic_probe(struct platform_device *pdev)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org

 drivers/net/ethernet/natsemi/xtsonic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linext-2026-1007.orig/drivers/net/ethernet/natsemi/xtsonic.c
+++ linext-2026-1007/drivers/net/ethernet/natsemi/xtsonic.c
@@ -197,7 +197,7 @@ out:
  * Actually probing is superfluous but we're paranoid.
  */
 
-int xtsonic_probe(struct platform_device *pdev)
+static int xtsonic_probe(struct platform_device *pdev)
 {
 	struct net_device *dev;
 	struct sonic_local *lp;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: natsemi: xtsonic: make probe function static
  2026-10-08 18:30 [PATCH net-next] net: natsemi: xtsonic: make probe function static Randy Dunlap
@ 2026-10-09  6:18 ` Björn Töpel
  0 siblings, 0 replies; 2+ messages in thread
From: Björn Töpel @ 2026-10-09  6:18 UTC (permalink / raw)
  To: Randy Dunlap, netdev
  Cc: patches, Randy Dunlap, Thomas Bogendoerfer, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni

Randy Dunlap <rdunlap@infradead.org> writes:

> Avoid a build warning by making the probe function static:
>
> drivers/net/ethernet/natsemi/xtsonic.c:200:5: warning: no previous prototype for 'xtsonic_probe' [-Wmissing-prototypes]
>   200 | int xtsonic_probe(struct platform_device *pdev)
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Björn Töpel <bjorn@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-09  6:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-08 18:30 [PATCH net-next] net: natsemi: xtsonic: make probe function static Randy Dunlap
2026-10-09  6:18 ` Björn Töpel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox