[PATCH net 0/3] net/mlx5e: Fix CQE moderation mode reporting and control

[Tariq Toukan <tariqt@nvidia.com>]

Hi,

This series by Yael fixes inconsistencies in how mlx5e reports and
configures the CQE moderation mode through ethtool.

mlx5e_params keeps two representations of CQE moderation: the private
flags (MLX5E_PFLAG_RX_CQE_BASED_MODER, MLX5E_PFLAG_TX_CQE_BASED_MODER)
and the fields rx_moder_use_cqe_mode / tx_moder_use_cqe_mode. Ethtool
get/set coalesce uses the fields, while the priv-flags path uses the
pflags. When the two disagree, the reported CQE moderation state is
wrong. In addition, commit bc541621f8ba ("net/mlx5e: Support ethtool cq
mode") added ETHTOOL_COALESCE_USE_CQE to the NIC ethtool ops but not to
the representor ones.

Patch 1 syncs the pflags with the capability-derived fields in
mlx5e_build_nic_params(), so that after channel attach or reopen the
private flags no longer remain zero while the fields reflect the
hardware configuration.

Patch 2 fixes the opposite direction. set_pflag_cqe_based_moder() now
also updates rx_moder_use_cqe_mode / tx_moder_use_cqe_mode, and resets
the RX/TX CQ moderation to the defaults of the new period mode, so that
ethtool -c no longer reports a stale CQE mode or stale rx-usecs after
toggling the priv flag.

Patch 3 adds ETHTOOL_COALESCE_USE_CQE to mlx5e_rep_ethtool_ops, so that
setting cqe-mode-rx/tx on a representor is no longer rejected with
EINVAL.

Regards,
Tariq

Yael Chemla (3):
  net/mlx5e: Sync CQE moderation pflags with coalesce params
  net/mlx5e: Sync CQE moderation params with pflags in
    set_pflag_cqe_based_moder
  net/mlx5e: Expose CQE moderation mode on representors

 drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 8 ++++++++
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c    | 4 ++++
 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c     | 3 ++-
 3 files changed, 14 insertions(+), 1 deletion(-)


base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e
-- 
2.44.0