From: Peter Hunt <peter.hunt@opengear.com>
To: netdev-bot+sashiko@kernel.org
Cc: loic.poulain@oss.qualcomm.com, Daniele Palmas <dnlplm@gmail.com>,
ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
mani@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v10 1/2] net: wwan: core: propagate modem control signals to port drivers
Date: Fri, 16 Oct 2026 14:56:51 -0600 [thread overview]
Message-ID: <20261016205651.502760-1-peter.hunt@opengear.com> (raw)
In-Reply-To: <179214346234.434549.2545307661462448073@kernel.org>
Thanks for the review.
[Medium] termios/TIOCM ioctls waiting behind a blocking write: this is
a trade-off discussed on v8, where Loic chose a single ops_lock for now,
with finer-grained locking possibly later. In v10 the lock is only held
around the termios/TIOCM state, never across a user copy, the wait is
interruptible, and ioctls that don't touch that state don't take it.
No in-tree driver implements both ->tx_blocking and ->dtr_rts, so the
circular wait you describe can't happen today. If the maintainers would
rather keep the termios/TIOCM state under a lock the TX path doesn't
hold, I'm happy to do that as a follow-up.
next prev parent reply other threads:[~2026-10-16 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:34 [PATCH net-next v10 0/2] net: wwan: support DTR/RTS on AT ports via MHI IP_CTRL Peter Hunt
2026-10-13 18:34 ` [PATCH net-next v10 1/2] net: wwan: core: propagate modem control signals to port drivers Peter Hunt
2026-10-16 9:37 ` netdev-bot+sashiko
2026-10-16 20:56 ` Peter Hunt [this message]
2026-10-16 19:46 ` Loic Poulain
2026-10-13 18:35 ` [PATCH net-next v10 2/2] net: wwan: mhi_wwan_ctrl: drive DTR/RTS via the IP_CTRL channel Peter Hunt
2026-10-16 9:37 ` netdev-bot+sashiko
2026-10-16 20:58 ` Peter Hunt
2026-10-16 19:47 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016205651.502760-1-peter.hunt@opengear.com \
--to=peter.hunt@opengear.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dnlplm@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox