Netdev List
 help / color / mirror / Atom feed
From: Peter Hunt <peter.hunt@opengear.com>
To: netdev-bot+sashiko@kernel.org
Cc: loic.poulain@oss.qualcomm.com, Daniele Palmas <dnlplm@gmail.com>,
	ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
	mani@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v10 2/2] net: wwan: mhi_wwan_ctrl: drive DTR/RTS via the IP_CTRL channel
Date: Fri, 16 Oct 2026 14:58:45 -0600	[thread overview]
Message-ID: <20261016205845.503392-1-peter.hunt@opengear.com> (raw)
In-Reply-To: <179214346368.434549.12561882856700666394@kernel.org>

Thanks for the review.

[Medium] a DTR/RTS request made while IP_CTRL is not bound is lost:
agreed. It needs IP_CTRL to bind after the AT port has been opened. On
the EM919x/EM929x, IP_CTRL (channels 18/19) is probed before DUN
(32/33), so outside async probing this only happens after a sysfs
unbind/rebind of mhi_wwan_dtr or a failed IP_CTRL probe. The fix is for
mhi_wwan_dtr_probe() to resend the current state of the AT ports on its
controller.

[Low] coalescing can swallow a DTR drop on a quick close and reopen:
agreed, a drop matters on its own for a modem set to AT&D2. The fix is
to never coalesce away a pending drop, and send it before the latest
state.

Both are corner cases outside normal operation, which I've tested on an
EM9291, including bursts of 10,000 DTR changes ending in either state.
I'd propose to address them in a small follow-up patch on top of this
series, but I'm happy to fold them into a v11 instead if the
maintainers prefer.

  reply	other threads:[~2026-10-16 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 18:34 [PATCH net-next v10 0/2] net: wwan: support DTR/RTS on AT ports via MHI IP_CTRL Peter Hunt
2026-10-13 18:34 ` [PATCH net-next v10 1/2] net: wwan: core: propagate modem control signals to port drivers Peter Hunt
2026-10-16  9:37   ` netdev-bot+sashiko
2026-10-16 20:56     ` Peter Hunt
2026-10-16 19:46   ` Loic Poulain
2026-10-13 18:35 ` [PATCH net-next v10 2/2] net: wwan: mhi_wwan_ctrl: drive DTR/RTS via the IP_CTRL channel Peter Hunt
2026-10-16  9:37   ` netdev-bot+sashiko
2026-10-16 20:58     ` Peter Hunt [this message]
2026-10-16 19:47   ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016205845.503392-1-peter.hunt@opengear.com \
    --to=peter.hunt@opengear.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dnlplm@gmail.com \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox