From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, j-rameshbabu@ti.com,
andrew+netdev@lunn.ch, c-vankar@ti.com, danishanwar@ti.com,
d-qiu@ti.com, davem@davemloft.net, fmaurer@redhat.com,
kuba@kernel.org, neelima@ti.com, pabeni@redhat.com,
praneeth@ti.com, pratheesh@ti.com, richardcochran@gmail.com,
horms@kernel.org, vigneshr@ti.com,
willemdebruijn.kernel@gmail.com, daniel.machon@microchip.com,
edumazet@kernel.org
Subject: Re: [PATCH net-next v9 2/8] hsr: Use skb_clone() while adding the HSR header
Date: Mon, 19 Oct 2026 18:07:00 +0200 [thread overview]
Message-ID: <20261019160700.oa7zrh8K@linutronix.de> (raw)
In-Reply-To: <179233869819.3135.906589936438355086@kernel.org>
On 2026-10-18 15:51:38 [+0000], netdev-bot+sashiko@kernel.org wrote:
>
> [Severity: Medium]
> Should the skb_cow_head() call above also reserve room for the skb
> metadata? It currently reserves only HSR_HLEN.
yes, it does.
Sebastian
next prev parent reply other threads:[~2026-10-19 16:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 14:43 [PATCH net-next v9 0/8] hsr: Add additional info to send/ receive skbs Sebastian Andrzej Siewior
2026-10-14 14:43 ` [PATCH net-next v9 1/8] hsr: Add header_ops::parse_protocol Sebastian Andrzej Siewior
2026-10-14 14:43 ` [PATCH net-next v9 2/8] hsr: Use skb_clone() while adding the HSR header Sebastian Andrzej Siewior
2026-10-16 9:09 ` Daniel Machon
2026-10-16 9:41 ` Sebastian Andrzej Siewior
2026-10-19 13:33 ` Sebastian Andrzej Siewior
2026-10-18 15:51 ` netdev-bot+sashiko
2026-10-19 16:07 ` Sebastian Andrzej Siewior [this message]
2026-10-14 14:43 ` [PATCH net-next v9 3/8] hsr: Add a magic header for sending PTP packets Sebastian Andrzej Siewior
2026-10-16 9:15 ` Daniel Machon
2026-10-16 9:48 ` Sebastian Andrzej Siewior
2026-10-18 15:51 ` netdev-bot+sashiko
2026-10-14 14:43 ` [PATCH net-next v9 4/8] hsr: Drop received " Sebastian Andrzej Siewior
2026-10-18 15:51 ` netdev-bot+sashiko
2026-10-14 14:43 ` [PATCH net-next v9 5/8] hsr: Use the port and header information in hsr_forward_skb() Sebastian Andrzej Siewior
2026-10-16 9:24 ` Daniel Machon
2026-10-16 9:56 ` Sebastian Andrzej Siewior
2026-10-18 15:51 ` netdev-bot+sashiko
2026-10-14 14:44 ` [PATCH net-next v9 6/8] hsr: Assign a socket for cloned skbs Sebastian Andrzej Siewior
2026-10-16 9:34 ` Daniel Machon
2026-10-16 9:56 ` Sebastian Andrzej Siewior
2026-10-14 14:44 ` [PATCH net-next v9 7/8] hsr: Move struct hsr_ethhdr to a global header Sebastian Andrzej Siewior
2026-10-16 9:38 ` Daniel Machon
2026-10-16 10:07 ` Sebastian Andrzej Siewior
2026-10-19 9:15 ` Daniel Machon
2026-10-14 14:44 ` [PATCH net-next v9 8/8] selftests: hsr: Add test for the inline PTP header on HSR Sebastian Andrzej Siewior
2026-10-18 15:51 ` netdev-bot+sashiko
2026-10-16 9:01 ` [PATCH net-next v9 0/8] hsr: Add additional info to send/ receive skbs Daniel Machon
2026-10-16 9:36 ` Sebastian Andrzej Siewior
2026-10-18 16:14 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019160700.oa7zrh8K@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=c-vankar@ti.com \
--cc=d-qiu@ti.com \
--cc=daniel.machon@microchip.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=j-rameshbabu@ti.com \
--cc=kuba@kernel.org \
--cc=neelima@ti.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=vigneshr@ti.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox