[PATCH net-next] net: ena: set admin device pointer before queue allocations

[PATCH net-next] net: ena: set admin device pointer before queue allocations

[Avi Weiss]

On the first probe, ena_com_admin_init() allocates the completion
contexts and admin SQ/CQ buffers before setting admin_queue->ena_dev.
Their allocation failure paths log through this pointer, which is
still NULL. A failed allocation therefore dereferences NULL instead
of returning -ENOMEM.

Set admin_queue->ena_dev before the first allocation so the helpers
can log errors and return -ENOMEM normally.

Fixes: da580ca8de2c ("net: ena: add device distinct log prefix to files")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
 drivers/net/ethernet/amazon/ena/ena_com.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 297fb36ab8c16..23b3ef50b8b6b 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -2000,6 +2000,8 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
 
 	spin_lock_init(&admin_queue->q_lock);
 
+	admin_queue->ena_dev = ena_dev;
+
 	ret = ena_com_init_comp_ctxt(admin_queue);
 	if (ret)
 		goto error;
@@ -2045,7 +2047,6 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
 	if (ret)
 		goto error;
 
-	admin_queue->ena_dev = ena_dev;
 	admin_queue->running_state = true;
 
 	return 0;

base-commit: fa5196392691051963726787944db872420dfa75
-- 
2.43.0

Re: [PATCH net-next] net: ena: set admin device pointer before queue allocations

[netdev-bot+sinfo]

Hi!

This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:

 - How the issue was discovered, e.g. hit in production, hit during
   development, syzbot report, manual code inspection, LLM or static
   analysis tool scan.

 - Whether the issue was actually triggered, or is only theoretical
   (e.g. found by code inspection). If it was triggered please include
   the symptoms, like the stack trace or error messages.

 - What hardware the change was tested on. For driver fixes please
   mention the device (and if relevant firmware version) used for
   testing, or say that the change was not tested on real hardware.

Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.

The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.

Re: [PATCH net-next] net: ena: set admin device pointer before queue allocations

[Arthur Kiyanovski]

On Mon, 09 Nov 2026 09:11:27 +0200, Avi Weiss <thnkslprpt@gmail.com> wrote:
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
> index 297fb36ab8c1..23b3ef50b8b6 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_com.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
> @@ -2045,7 +2047,6 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
>  	if (ret)
>  		goto error;
>  
> -	admin_queue->ena_dev = ena_dev;
>  	admin_queue->running_state = true;
>  
>  	return 0;

1. This is a bug fix, so it should go to net and not net-next.

2. Like your other patches, this one has already been applied to the
amzn-drivers repository:

https://github.com/amzn/amzn-drivers/commit/7d1dc4341d4f8376c7affdc2a97c7e012118beaa

Therefore please do the following:

2.1. Add a From: tag to give credit to Wajeeh Atrash, who wrote this fix:

From: Wajeeh Atrash <atrwajee@amazon.com>

2.2. Wajeeh has agreed, please also add:


It should be added before your Signed-off-by:

2.3. Move "admin_queue->ena_dev = ena_dev;" to the same place as in the
github commit, which is directly above the q_dmadev assignment:

        admin_queue->ena_dev = ena_dev;
        admin_queue->q_dmadev = ena_dev->dmadev;

I don't see a clear advantage to the location in your patch, so I would
rather have both drivers aligned.

Signed-off-by: Wajeeh Atrash <atrwajee@amazon.com>

-- 
Arthur Kiyanovski <akiyano@amazon.com>

Re: [PATCH net-next] net: ena: set admin device pointer before queue allocations

[Arthur Kiyanovski]

On 2026-11-10 18:42:32+00:00, Arthur Kiyanovski wrote:
> On Mon, 09 Nov 2026 09:11:27 +0200, Avi Weiss <thnkslprpt@gmail.com> wrote:
> 
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
> > index 297fb36ab8c1..23b3ef50b8b6 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_com.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
> > @@ -2045,7 +2047,6 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
> >  	if (ret)
> >  		goto error;
> >  
> > -	admin_queue->ena_dev = ena_dev;
> >  	admin_queue->running_state = true;
> >  
> >  	return 0;
> 
> 1. This is a bug fix, so it should go to net and not net-next.
> 
> 2. Like your other patches, this one has already been applied to the
> amzn-drivers repository:
> 
> https://github.com/amzn/amzn-drivers/commit/7d1dc4341d4f8376c7affdc2a97c7e012118beaa
> 
> Therefore please do the following:
> 
> 2.1. Add a From: tag to give credit to Wajeeh Atrash, who wrote this fix:
> 
> From: Wajeeh Atrash <atrwajee@amazon.com>
> 
> 2.2. Wajeeh has agreed, please also add:
> 
> 
> It should be added before your Signed-off-by:
> 
> 2.3. Move "admin_queue->ena_dev = ena_dev;" to the same place as in the
> github commit, which is directly above the q_dmadev assignment:
> 
>         admin_queue->ena_dev = ena_dev;
>         admin_queue->q_dmadev = ena_dev->dmadev;
> 
> I don't see a clear advantage to the location in your patch, so I would
> rather have both drivers aligned.
> 
> Signed-off-by: Wajeeh Atrash <atrwajee@amazon.com>

Two corrections to the commit message, plus two requests for v2.

1. The From: line must be the very first line of the message body,
above the changelog - not down among the tags. git am consumes it
from there into the commit's author field, after which it does not
appear in the commit message at all. Placed next to the Fixes: tag
it is not consumed: the author stays you, and the line survives in
the permanent changelog as plain text.

So the body should start:

-  From: Wajeeh Atrash <atrwajee@amazon.com>

-  On the first probe, ena_com_admin_init() allocates the completion
-  contexts ...

Equivalently, set him as the author locally and let format-patch
emit the line for you:

  git commit --amend --author="Wajeeh Atrash <atrwajee@amazon.com>"

2. Wajeeh's Signed-off-by: is missing from your draft - my previous
mail dropped the line by accident, sorry. The tags should end:

- Fixes: da580ca8de2c ("net: ena: add device distinct log prefix to files")
- Signed-off-by: Wajeeh Atrash <atrwajee@amazon.com>
- Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>

Both are needed. Once From: changes the author, netdev's
verify_signedoff check requires a sign-off matching the author as
well as one matching the submitter.

3. Please send the three ENA patches as one series against net, with
a cover letter, instead of three separate mails.

4. Please state how the issue was discovered and validated, and how
the fix was tested, as required by the "Bug fixes" section of
Documentation/process/maintainer-netdev.rst. For a driver fix the
testing statement has to say which hardware it was tested on, or say
plainly that it was not tested on hardware.

Keep the sentence about the standalone driver in the commit message -
unlike a link below the ---, it survives the apply.