Re: [PATCH net-next v6 1/2] netlink: specs: add ovs_flow del and set operations

[Minxi Hou <houminxi@gmail.com>]

On 2026-11-08 12:39, Sashiko wrote:
> [Medium] The ufid doc promises that the flow is indexed by that value,
> which does not hold for a value the kernel rejects.

v7 rewrites that paragraph. A value longer than 16 octets is read as if
the attribute were absent, so a del that carries such a ufid and no key
flushes the data path, and a new request indexes the flow by its key
instead. A zero-length value never reaches the handler, because the core
enforces the minimum length of one even when strict validation is
skipped, and a dump that parses the same policy fails the same way. The
spec records that minimum now.

Measured on the current tree, so it is not from the code alone: a GET
with an empty ufid returns -ERANGE and the same GET with four octets
returns -ENOENT, which means the attribute does reach the kernel.

> [Medium] The get reply also carries the last-used time and the TCP
> flags, which the reply list omitted.

Added. ovs_flow_cmd_fill_stats() adds both for a get and for a dump, and
the reply list names them in the order the helper writes them.

pw-bot: cr