Netdev List
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: netdev@vger.kernel.org
Cc: Donald Hunter <donald.hunter@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Aaron Conole <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	dev@openvswitch.org
Subject: Re: [PATCH net-next v6 2/2] netlink: specs: add ovs datapath and vport set operations
Date: Tue, 10 Nov 2026 12:52:05 -0500	[thread overview]
Message-ID: <20261110175205.978410-1-houminxi@gmail.com> (raw)
In-Reply-To: <179414156884.994134.5015506800657224516@kernel.org>

On 2026-11-08 12:39, Sashiko wrote:
> [Low] The min length has no effect for this family.
> [Low] The vport set list names attributes the kernel rejects.

On the first one, the mechanism is in the generator: TypeScalar.__init__
calls _init_checks() only when the family is not classic
(tools/net/ynl/pyynl/ynl_gen_c.py:375), so for these families a check
documents the kernel policy and nothing else. The kernel enforces it with
NLA_POLICY_MIN(NLA_S32, 0). v7 keeps the declaration and changes the type
to s32, which does reach the generated request code: it now calls
ynl_attr_put_s32() for the attribute.

One disclosure on the same point. v7 also adds a max check on
masks-cache-size, for the same reason, and it does not reach the
generated code either. If a check that generates nothing is worse than no
check, say so and I will drop both rather than leave them in the spec.

The vport set list no longer carries the ifindex or the options, and the
doc says that a request with either of them is rejected.

pw-bot: cr

      reply	other threads:[~2026-11-10 17:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 12:06 [PATCH net-next v6 0/2] netlink: specs: fill in the missing ovs operations Minxi Hou
2026-11-07 12:06 ` [PATCH net-next v6 1/2] netlink: specs: add ovs_flow del and set operations Minxi Hou
2026-11-08 12:39   ` netdev-bot+sashiko
2026-11-10 17:51     ` Minxi Hou
2026-11-07 12:06 ` [PATCH net-next v6 2/2] netlink: specs: add ovs datapath and vport " Minxi Hou
2026-11-08 12:39   ` netdev-bot+sashiko
2026-11-10 17:52     ` Minxi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110175205.978410-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=aconole@redhat.com \
    --cc=dev@openvswitch.org \
    --cc=donald.hunter@gmail.com \
    --cc=echaudro@redhat.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox