Netdev List
 help / color / mirror / Atom feed
From: Imre Kaloz <kaloz@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sgi: ioc3-eth: apply the DMA attributes only to 64-bit addresses
Date: Mon, 16 Nov 2026 11:41:12 +0100	[thread overview]
Message-ID: <20261116104113.5946-1-kaloz@kernel.org> (raw)
In-Reply-To: <179473759964.2199510.1259617691806814840@kernel.org>

> Can the code currently in the tree ever reach this branch?

No. On IP27 and IP30 every IOC3 DMA address has a nonzero target
widget in bits 63:60. The branch is for the IP35 series, where an
IOC3 behind an XBridge or PIC uses the 32-bit window. v2 says so in
the commit message:

  https://lore.kernel.org/all/20261116102115.27574-1-kaloz@kernel.org/

> Does the window path rely on platform code setting the D32 bits in
> b_device for the IOC3 slot?

It does, and nothing sets them today. On a Fuel both XBridges leave
PREF, PRECISE, COH and BARRIER clear in every b_device register,
including the IOC3 slot (0x180010f8). That belongs to the bridge code
in the IP35 series, which will set the attributes for slots that use
the window. ioc3-eth itself needs no change for it.

> Should the ERBAR value be decided from the RX descriptor ring
> address?

The IP35 series picks the window per device, not per address: an IOC3
behind an XBridge or PIC gets a 32-bit bus_dma_limit and SWIOTLB
bounces anything above it. The ring and every buffer of one IOC3
therefore use the same form.


Thanks,
Imre

  reply	other threads:[~2026-11-16 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  9:51 [PATCH net-next 0/2] net: sgi: ioc3-eth: two changes for the IOC3 on SGI IP35 machines Imre Kaloz
2026-11-11  9:51 ` [PATCH net-next 1/2] net: sgi: ioc3-eth: apply the DMA attributes only to 64-bit addresses Imre Kaloz
2026-11-15 10:13   ` netdev-bot+sashiko
2026-11-16 10:41     ` Imre Kaloz [this message]
2026-11-11  9:51 ` [PATCH net-next 2/2] net: sgi: ioc3-eth: fall back to the platform MAC address Imre Kaloz
2026-11-15 10:13   ` netdev-bot+sashiko
2026-11-16 10:41     ` Imre Kaloz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116104113.5946-1-kaloz@kernel.org \
    --to=kaloz@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox