Netdev List
 help / color / mirror / Atom feed
From: Imre Kaloz <kaloz@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: sgi: ioc3-eth: fall back to the platform MAC address
Date: Mon, 16 Nov 2026 11:41:13 +0100	[thread overview]
Message-ID: <20261116104113.5946-2-kaloz@kernel.org> (raw)
In-Reply-To: <179473760071.2199510.16065103101920438822@kernel.org>

> Can eth_platform_get_mac_address() ever succeed for this device?

With the IP35 series it does: that series provides
arch_get_platform_mac_address(), which reads the address from the L1
system controller. Without it, as you say, it never does.

> Does this ordering let the platform address win before the 1-wire
> PROM has had a chance to appear?

Yes, and it matters for an IOC3 PCI card such as the CAD Duo, which
carries its own MAC PROM. The system-board IOC3 on these machines has
no PROM; a card in a PCI slot does.

> Could IP27/IP30 boards that do have a DS250x MAC PROM end up with a
> random MAC here?

Yes, with the w1 drivers as modules loaded after the deferred probe
timeout.

v2 takes the address from a device property instead. The IOC3 MFD
driver will attach it only to the Ethernet cell of the system-board
IOC3 that has no PROM, so every other IOC3 keeps waiting for its
PROM as before. The random fallback is gone:

  https://lore.kernel.org/all/20261116102115.27574-1-kaloz@kernel.org/

> ioc3eth_probe() never calls platform_set_drvdata(pdev, dev)
> [...]
> Is the shared IRQ handler safe with the current ordering in
> ioc3eth_probe()?

Both are real. I reproduced them on a Fuel by unbinding the device
through sysfs, the second one with CONFIG_DEBUG_SHIRQ, and the fixes
are posted separately to net:

  https://lore.kernel.org/all/20261116101934.25910-1-kaloz@kernel.org/

pw-bot: cr


Thanks,
Imre

      reply	other threads:[~2026-11-16 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  9:51 [PATCH net-next 0/2] net: sgi: ioc3-eth: two changes for the IOC3 on SGI IP35 machines Imre Kaloz
2026-11-11  9:51 ` [PATCH net-next 1/2] net: sgi: ioc3-eth: apply the DMA attributes only to 64-bit addresses Imre Kaloz
2026-11-15 10:13   ` netdev-bot+sashiko
2026-11-16 10:41     ` Imre Kaloz
2026-11-11  9:51 ` [PATCH net-next 2/2] net: sgi: ioc3-eth: fall back to the platform MAC address Imre Kaloz
2026-11-15 10:13   ` netdev-bot+sashiko
2026-11-16 10:41     ` Imre Kaloz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116104113.5946-2-kaloz@kernel.org \
    --to=kaloz@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox