Netdev List
 help / color / mirror / Atom feed
* [PATCH net 0/4] eth: fbnic: miscellaneous driver fixes
@ 2026-11-16 20:29 Dimitri Daskalakis
  2026-11-16 20:29 ` [PATCH net 1/4] eth: fbnic: wait on the correct queues in fbnic_queue_stop() Dimitri Daskalakis
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Dimitri Daskalakis @ 2026-11-16 20:29 UTC (permalink / raw)
  To: David S. Miller
  Cc: Alexander Duyck, Jakub Kicinski, kernel-team, Andrew Lunn,
	Eric Dumazet, Paolo Abeni, Shuah Khan, Mohsin Bashir,
	Mike Marciniszyn (Meta), Stanislav Fomichev, Bobby Eshleman,
	Björn Töpel, Breno Leitao, Simon Horman, Mina Almasry,
	Vadim Fedorenko, Dimitri Daskalakis, netdev, Dimitri Daskalakis

From: Dimitri Daskalakis <daskald@meta.com>

AI identified several bugs while I was working on unrelated parts of the
driver. fbnic_queue_stop() always waits on queue 0 to idle for rx queues.
fbnic_get_ts_stats() dereferences a NULL pointer when the interface is down.
And fbnic_{set|reset}_netif_napi does not account for disabled rings.

All bugs were verified on HW, and a new stats selftest was added to identify
other drivers with the same timestamp stats mishandling.

Dimitri Daskalakis (4):
  eth: fbnic: wait on the correct queues in fbnic_queue_stop()
  eth: fbnic: skip disabled Tx rings when setting the queue NAPI
  eth: fbnic: skip freed Tx rings in fbnic_get_ts_stats()
  selftests: drv-net: stats: query timestamping stats while down

 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  3 +++
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 20 ++++++++++++---
 tools/testing/selftests/drivers/net/stats.py  | 25 ++++++++++++++++++-
 3 files changed, 43 insertions(+), 5 deletions(-)

-- 
2.52.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-16 20:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 20:29 [PATCH net 0/4] eth: fbnic: miscellaneous driver fixes Dimitri Daskalakis
2026-11-16 20:29 ` [PATCH net 1/4] eth: fbnic: wait on the correct queues in fbnic_queue_stop() Dimitri Daskalakis
2026-11-16 20:29 ` [PATCH net 2/4] eth: fbnic: skip disabled Tx rings when setting the queue NAPI Dimitri Daskalakis
2026-11-16 20:29 ` [PATCH net 3/4] eth: fbnic: skip freed Tx rings in fbnic_get_ts_stats() Dimitri Daskalakis
2026-11-16 20:29 ` [PATCH net 4/4] selftests: drv-net: stats: query timestamping stats while down Dimitri Daskalakis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox