netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Joyner <eric.joyner@amd.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Joyner <eric.joyner@amd.com>, <netdev@vger.kernel.org>,
	<brett.creeley@amd.com>, <andrew+netdev@lunn.ch>,
	<davem@davemloft.net>, <pabeni@redhat.com>, <horms@kernel.org>,
	<vadim.fedorenko@linux.dev>, <nikhil.rao@amd.com>,
	<edumazet@kernel.org>
Subject: Re: [PATCH net-next v3 2/5] ionic: report the configured FEC mode in  ethtool_fecparam.fec
Date: Mon, 16 Nov 2026 15:19:58 -0800	[thread overview]
Message-ID: <20261116232001.2453595-1-eric.joyner@amd.com> (raw)
In-Reply-To: <20261110212621.2294782-1-kuba@kernel.org>

On Tue, 10 Nov 2026 13:26:21 -0800 Jakub Kicinski wrote:
> Should ionic_get_link_ksettings() add FEC_NONE to supported, and also to
> advertising when config.fec_type is IONIC_PORT_FEC_TYPE_NONE?

Yes, v4 adds a patch before this one that does both.

> A related issue is pre-existing and not introduced by this patch.
> ionic_get_link_ksettings() hardcodes RS and BaseR as supported for every
> transceiver and speed. It ignores the firmware's per-port list in
> union ionic_port_identity.fec_type[4].

Firmware doesn't fill in that list; it is always zero. Since the driver
can't tell which FEC modes a given port supports, the supported list
holds every mode an ionic device can use, and firmware rejects a request
for a mode the port can't run. The new patch says so in a comment and in
its commit message.

v4: https://lore.kernel.org/r/20261116-ionic-get-fec-stats-v4-0-d25cae9f1e87@amd.com

Thanks,
Eric

  reply	other threads:[~2026-11-16 23:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 21:19 [PATCH net-next v3 0/5] ionic: FEC reporting fixes and .get_fec_stats handler Eric Joyner
2026-11-04 21:19 ` [PATCH net-next v3 1/5] ionic: write the extra_stats invalid markers one counter at a time Eric Joyner
2026-11-04 21:19 ` [PATCH net-next v3 2/5] ionic: report the configured FEC mode in ethtool_fecparam.fec Eric Joyner
2026-11-10 21:26   ` Jakub Kicinski
2026-11-16 23:19     ` Eric Joyner [this message]
2026-11-04 21:19 ` [PATCH net-next v3 3/5] ionic: map the FEC type through a helper in ionic_get_fecparam() Eric Joyner
2026-11-04 21:19 ` [PATCH net-next v3 4/5] ionic: report the operational FEC mode from ethtool --show-fec Eric Joyner
2026-11-10 21:26   ` Jakub Kicinski
2026-11-16 23:19     ` Eric Joyner
2026-11-04 21:19 ` [PATCH net-next v3 5/5] ionic: Add .get_fec_stats ethtool handler Eric Joyner
2026-11-09 19:35 ` [PATCH net-next v3 0/5] ionic: FEC reporting fixes and .get_fec_stats handler Eric Joyner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116232001.2453595-1-eric.joyner@amd.com \
    --to=eric.joyner@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=brett.creeley@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikhil.rao@amd.com \
    --cc=pabeni@redhat.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).