Netdev List
 help / color / mirror / Atom feed
* [PATCH iwl-net] i40e: hold mac_filter_hash_lock while validating VF cloud filters
@ 2026-11-17  3:15 Changyul Lee
  0 siblings, 0 replies; only message in thread
From: Changyul Lee @ 2026-11-17  3:15 UTC (permalink / raw)
  To: Tony Nguyen, Przemek Kitszel
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, intel-wired-lan, netdev, linux-kernel, Changyul Lee

i40e_validate_cloud_filter() runs in the VF message path, which holds
neither RTNL nor vsi->mac_filter_hash_lock. It looks up the destination
MAC with i40e_find_mac() and walks vsi->mac_filter_hash for the VLAN
without the lock. Meanwhile the host can change the VF MAC or port VLAN
with i40e_ndo_set_vf_mac() or i40e_ndo_set_vf_port_vlan(), which delete
filters under the lock and free them in __i40e_del_filter() or
i40e_sync_vsi_filters(). The lookup and the walk can then read a freed
struct i40e_mac_filter.

Do the lookup and the walk under mac_filter_hash_lock, as
i40e_vc_add_mac_addr_msg() does, and do not use the filter after
dropping the lock.

Fixes: e284fc280473 ("i40e: Add and delete cloud filter")
Signed-off-by: Changyul Lee <lcy8047@gmail.com>
---
Found with a static analysis tool we are developing.

Compile-tested only, with x86_64_defconfig plus PCI_IOV, I40E and W=1.

 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 74b6c0ed8480..da1f1a9c4124 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -3624,9 +3624,11 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf,
 	 */
 	if (mask.dst_mac[0] && !mask.dst_ip[0]) {
 		vsi = pf->vsi[vf->lan_vsi_idx];
+		spin_lock_bh(&vsi->mac_filter_hash_lock);
 		f = i40e_find_mac(vsi, data.dst_mac);
 
 		if (!f) {
+			spin_unlock_bh(&vsi->mac_filter_hash_lock);
 			dev_info(&pf->pdev->dev,
 				 "Destination MAC %pM doesn't belong to VF %d\n",
 				 data.dst_mac, vf->vf_id);
@@ -3641,6 +3643,10 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf,
 					break;
 				}
 			}
+		}
+		spin_unlock_bh(&vsi->mac_filter_hash_lock);
+
+		if (mask.vlan_id) {
 			if (!found) {
 				dev_info(&pf->pdev->dev,
 					 "VF %d doesn't have any VLAN id %u\n",

base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
-- 
2.43.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-17  3:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  3:15 [PATCH iwl-net] i40e: hold mac_filter_hash_lock while validating VF cloud filters Changyul Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox