Netdev List
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@google.com>
To: Eric Dumazet <edumazet@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	 "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	 Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org
Subject: [PATCH v1 net 0/8] tcp: Misc fixes for tcp_v[46]_err().
Date: Tue, 17 Nov 2026 05:35:18 +0000	[thread overview]
Message-ID: <20261117053543.84032-1-kuniyu@google.com> (raw)

A packetdrill-equipped LLM found a bunch of bugs with repro.

This is the first series fixing bugs in tcp_v4_err() and
tcp_v6_err().

Patches 1-5, 7, and 8 are fixes, and Patch 6 is a selftest
for the bugs fixed by Patches 1-5.


Kuniyuki Iwashima (8):
  tcp: Don't accept ICMP for SND.NXT in TCP_SYN_SENT.
  tcp: Don't use inner IP TTL for IP_MINTTL in tcp_v4_err().
  tcp: Don't bypass GTSM check for reqsk.
  tcp: Fix reqsk abort condition on ICMP errors.
  tcp: Check ip_sk_accept_pmtu() in tcp_v4_err().
  selftest: net: packetdrill: Add ICMP and ICMPv6 tests.
  tcp: Pass inet_sdif() to __inet_lookup_established() in tcp_v4_err().
  tcp: Pass inet6_iif() to __inet6_lookup_established() in tcp_v6_err().

 net/ipv4/tcp_ipv4.c                           |  42 ++++---
 net/ipv6/tcp_ipv6.c                           |  33 ++++--
 .../net/packetdrill/tcp_icmp_ipv4.pkt         |  98 ++++++++++++++++
 .../net/packetdrill/tcp_icmp_ipv6.pkt         | 111 ++++++++++++++++++
 4 files changed, 253 insertions(+), 31 deletions(-)
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_icmp_ipv4.pkt
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_icmp_ipv6.pkt

-- 
2.56.0.679.gc527c65306-goog


             reply	other threads:[~2026-11-17  5:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:35 Kuniyuki Iwashima [this message]
2026-11-17  5:35 ` [PATCH v1 net 1/8] tcp: Don't accept ICMP for SND.NXT in TCP_SYN_SENT Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 2/8] tcp: Don't use inner IP TTL for IP_MINTTL in tcp_v4_err() Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 3/8] tcp: Don't bypass GTSM check for reqsk Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 4/8] tcp: Fix reqsk abort condition on ICMP errors Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 5/8] tcp: Check ip_sk_accept_pmtu() in tcp_v4_err() Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 6/8] selftest: net: packetdrill: Add ICMP and ICMPv6 tests Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 7/8] tcp: Pass inet_sdif() to __inet_lookup_established() in tcp_v4_err() Kuniyuki Iwashima
2026-11-17  5:35 ` [PATCH v1 net 8/8] tcp: Pass inet6_iif() to __inet6_lookup_established() in tcp_v6_err() Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117053543.84032-1-kuniyu@google.com \
    --to=kuniyu@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox