From: Kuniyuki Iwashima <kuniyu@google.com>
To: Eric Dumazet <edumazet@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH v1 net 6/8] selftest: net: packetdrill: Add ICMP and ICMPv6 tests.
Date: Tue, 17 Nov 2026 05:35:24 +0000 [thread overview]
Message-ID: <20261117053543.84032-7-kuniyu@google.com> (raw)
In-Reply-To: <20261117053543.84032-1-kuniyu@google.com>
tcp_icmp_ipv4.pkt and tcp_icmp_ipv6.pkt cover the scenarios
fixed by the preceding patches.
tcp_v6_err() already checks the outer hop limit and
ip6_sk_accept_pmtu(), so Test 2 and 5 in tcp_icmp_ipv6.pkt
pass without the series.
ICMP and ICMPv6 behaviour are unlikely to change, so splitting
into multiple files per test case is not worth it.
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
---
.../net/packetdrill/tcp_icmp_ipv4.pkt | 98 ++++++++++++++++
.../net/packetdrill/tcp_icmp_ipv6.pkt | 111 ++++++++++++++++++
2 files changed, 209 insertions(+)
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_icmp_ipv4.pkt
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_icmp_ipv6.pkt
diff --git a/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv4.pkt b/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv4.pkt
new file mode 100644
index 000000000000..122bf9a14862
--- /dev/null
+++ b/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv4.pkt
@@ -0,0 +1,98 @@
+// SPDX-License-Identifier: GPL-2.0
+--ip_version=ipv4
+
+`./defaults.sh`
+
+// Test 1: Client in TCP_SYN_SENT rejects ICMP quoting seq == snd_nxt (RFC 5927 4.1)
+// In SYN_SENT, SND.UNA = ISN, SND.NXT = ISN + 1.
+// The sequence number in ICMP must satisfy SND.UNA <= SEG.SEQ < SND.NXT.
+// An ICMP message quoting seq == 1 (snd_nxt) must be dropped, while seq == 0 (snd_una) aborts.
+ 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+ +0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+ +0 > S 0:0(0) <...>
+ // Out-of-window ICMP quoting seq == 1 (snd_nxt) must be dropped
+ +0 < icmp unreachable host_unreachable [1:1(0)]
+ // Socket stays in TCP_SYN_SENT, so SYN retransmission occurs after 1s
+ +1 > S 0:0(0) <...>
+ // In-window ICMP quoting seq == 0 (snd_una) is accepted and aborts connection
+ +0 < icmp unreachable host_unreachable [0:0(0)]
+ +0 %{ assert tcpi_state == TCP_CLOSE }%
+ +0 getsockopt(3, SOL_SOCKET, SO_ERROR, [EHOSTUNREACH], [4]) = 0
+ +0 close(3) = 0
+
+// Test 2: Client with IP_MINTTL (21) checks outer IP TTL in tcp_v4_err()
+// An ICMP with outer TTL < min_ttl (250) must be dropped, while outer TTL >= min_ttl
+// must be accepted even though the quoted inner IP header has lower TTL (64).
+ +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_IP, 21, [250], 4) = 0
+ +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+ +0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+ +0 > S 0:0(0) <...>
+ // Outer TTL 10 < min_ttl (250): dropped, socket stays in TCP_SYN_SENT
+ +0 < (ttl 10) icmp unreachable host_unreachable [0:0(0)]
+ +1 > S 0:0(0) <...>
+ // Outer TTL 255 >= min_ttl (250): accepted, socket aborts
+ +0 < (ttl 255) icmp unreachable host_unreachable [0:0(0)]
+ +0 %{ assert tcpi_state == TCP_CLOSE }%
+ +0 getsockopt(3, SOL_SOCKET, SO_ERROR, [EHOSTUNREACH], [4]) = 0
+ +0 close(3) = 0
+
+// Test 3: Listener with IP_MINTTL (21) checks TTL before reqsk handling
+// An incoming fatal ICMP with outer TTL < min_ttl (255) must not abort TCP_NEW_SYN_RECV,
+// while outer TTL >= min_ttl (255) must abort it.
+ +0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 setsockopt(3, SOL_IP, 21, [255], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 10) = 0
+ +0 < (ttl 255) S 0:0(0) win 65535 <mss 1460,nop,nop,sackOK>
+ +0 > (ttl 64) S. 0:0(0) ack 1 <...>
+ // Outer TTL 10 < min_ttl (255): dropped, reqsk survives
+ +0 < (ttl 10) icmp unreachable port_unreachable [0:0(0)]
+ +1 > (ttl 64) S. 0:0(0) ack 1 <...>
+ // Outer TTL 255 >= min_ttl (255): accepted, fatal ICMP aborts reqsk
+ +0 < (ttl 255) icmp unreachable port_unreachable [0:0(0)]
+ +0 < (ttl 255) . 1:1(0) ack 1 win 65535
+ +0 > R 1:1(0)
+ +0 close(3) = 0
+
+// Test 4: Server in TCP_NEW_SYN_RECV does not abort on soft errors but aborts on fatal error
+ +0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 10) = 0
+ +0 < S 0:0(0) win 65535 <mss 1460,nop,nop,sackOK>
+ +0 > S. 0:0(0) ack 1 <...>
+ // 4a: Soft errors must not abort reqsk
+ +0 < icmp unreachable host_unreachable [0:0(0)]
+ +0 < icmp unreachable net_unreachable [0:0(0)]
+ +0 < icmp time_exceeded [0:0(0)]
+ +0 < icmp parameter_problem [0:0(0)]
+ +1 > S. 0:0(0) ack 1 <...>
+ // 4b: Fatal error (port_unreachable) must abort reqsk
+ +0 < icmp unreachable port_unreachable [0:0(0)]
+ // Remote sends 3rd ACK: listener responds with RST because reqsk was aborted
+ +0 < . 1:1(0) ack 1 win 65535
+ +0 > R 1:1(0)
+ +0 close(3) = 0
+
+// Test 5: Socket with IP_PMTUDISC_INTERFACE ignores ICMP_FRAG_NEEDED
+// Socket configured with IP_PMTUDISC_INTERFACE (4) must not overwrite MTU
+// upon receiving ICMP_DEST_UNREACH with code ICMP_FRAG_NEEDED.
+ +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 1) = 0
+ +0 < S 0:0(0) win 65535 <mss 1460,sackOK,nop,nop,nop,wscale 8>
+ +0 > S. 0:0(0) ack 1 <...>
+ +0 < . 1:1(0) ack 1 win 257
+ +0 accept(3, ..., ...) = 4
+ +0 setsockopt(4, SOL_IP, IP_MTU_DISCOVER, [4], 4) = 0
+ +0 getsockopt(4, SOL_IP, IP_MTU, [1500], [4]) = 0
+ +0 write(4, ..., 1000) = 1000
+ +0 > P. 1:1001(1000) ack 1 <...>
+ +0 < icmp unreachable frag_needed mtu 1200 [1:1001(1000)]
+ +0 getsockopt(4, SOL_IP, IP_MTU, [1500], [4]) = 0
+ +0 close(4) = 0
+ +0 close(3) = 0
diff --git a/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv6.pkt b/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv6.pkt
new file mode 100644
index 000000000000..bd0cc365a088
--- /dev/null
+++ b/tools/testing/selftests/net/packetdrill/tcp_icmp_ipv6.pkt
@@ -0,0 +1,111 @@
+// SPDX-License-Identifier: GPL-2.0
+--ip_version=ipv6
+
+`./defaults.sh`
+
+// Test 1: Client in TCP_SYN_SENT rejects ICMPv6 quoting seq == snd_nxt (RFC 5927 4.1)
+// In SYN_SENT, SND.UNA = ISN, SND.NXT = ISN + 1.
+// The sequence number in ICMP must satisfy SND.UNA <= SEG.SEQ < SND.NXT.
+// An ICMP message quoting seq == 1 (snd_nxt) must be dropped, while seq == 0 (snd_una) aborts.
+ 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+ +0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+ +0 > S 0:0(0) <...>
+ // Out-of-window ICMPv6 quoting seq == 1 (snd_nxt) must be dropped
+ +0 < icmp unreachable address_unreachable [1:1(0)]
+ // Socket stays in TCP_SYN_SENT, so SYN retransmission occurs after 1s
+ +1 > S 0:0(0) <...>
+ // In-window ICMPv6 quoting seq == 0 (snd_una) is accepted and aborts connection
+ +0 < icmp unreachable address_unreachable [0:0(0)]
+ +0 %{ assert tcpi_state == TCP_CLOSE }%
+ +0 getsockopt(3, SOL_SOCKET, SO_ERROR, [EHOSTUNREACH], [4]) = 0
+ +0 close(3) = 0
+
+// Test 2: Client with IPV6_MINHOPCOUNT (73) checks outer IPv6 hop_limit in tcp_v6_err()
+// An ICMPv6 with outer hop_limit < min_hopcount (250) must be dropped, while outer
+// hop_limit >= min_hopcount must be accepted even though the quoted inner hop_limit is 64.
+ +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_IPV6, 73, [250], 4) = 0
+ +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+ +0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+ +0 > S 0:0(0) <...>
+ // Outer hop_limit 10 < min_hopcount (250): dropped, socket stays in TCP_SYN_SENT
+ +0 < (ttl 10) icmp unreachable address_unreachable [0:0(0)]
+ +1 > S 0:0(0) <...>
+ // Outer hop_limit 255 >= min_hopcount (250): accepted, socket aborts
+ +0 < (ttl 255) icmp unreachable address_unreachable [0:0(0)]
+ +0 %{ assert tcpi_state == TCP_CLOSE }%
+ +0 getsockopt(3, SOL_SOCKET, SO_ERROR, [EHOSTUNREACH], [4]) = 0
+ +0 close(3) = 0
+
+// Test 3: Listener with IPV6_MINHOPCOUNT (73) checks hop_limit before reqsk handling
+// An incoming fatal ICMPv6 with outer hop_limit < min_hopcount (255) must not abort
+// TCP_NEW_SYN_RECV, while outer hop_limit >= min_hopcount (255) must abort it.
+ +0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 setsockopt(3, SOL_IPV6, 73, [255], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 10) = 0
+ +0 < (ttl 255) S 0:0(0) win 65535 <mss 1440,nop,nop,sackOK>
+ +0 > (ttl 64) S. 0:0(0) ack 1 <...>
+ // Outer hop_limit 10 < min_hopcount (255): dropped, reqsk survives
+ +0 < (ttl 10) icmp unreachable port_unreachable [0:0(0)]
+ +1 > (ttl 64) S. 0:0(0) ack 1 <...>
+ // Outer hop_limit 255 >= min_hopcount (255): accepted, fatal ICMPv6 aborts reqsk
+ +0 < (ttl 255) icmp unreachable port_unreachable [0:0(0)]
+ +0 < (ttl 255) . 1:1(0) ack 1 win 65535
+ +0 > R 1:1(0)
+ +0 close(3) = 0
+
+// Test 4: Server in TCP_NEW_SYN_RECV does not abort on soft error or
+// non-UNK_NEXTHDR ICMPV6_PARAMPROB, but aborts on fatal error or
+// ICMPV6_UNK_NEXTHDR.
+ +0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 10) = 0
+ +0 < S 0:0(0) win 65535 <mss 1440,nop,nop,sackOK>
+ +0 > S. 0:0(0) ack 1 <...>
+ // 4a: Soft error (address_unreachable) must not abort reqsk
+ +0 < icmp unreachable address_unreachable [0:0(0)]
+ +1 > S. 0:0(0) ack 1 <...>
+ // 4b: Non-UNK_NEXTHDR parameter problem (header_field) must not abort reqsk
+ +0 < icmp parameter_problem header_field [0:0(0)]
+ +2 > S. 0:0(0) ack 1 <...>
+ // 4c: ICMPV6_UNK_NEXTHDR parameter problem (unknown_next_header) must abort reqsk
+ +0 < icmp parameter_problem unknown_next_header [0:0(0)]
+ // Remote sends 3rd ACK: listener responds with RST because reqsk was aborted
+ +0 < . 1:1(0) ack 1 win 65535
+ +0 > R 1:1(0)
+ +0 close(3) = 0
+ // 4d: Fatal unreachable error (port_unreachable) must abort reqsk
+ +0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 10) = 0
+ +0 < S 0:0(0) win 65535 <mss 1440,nop,nop,sackOK>
+ +0 > S. 0:0(0) ack 1 <...>
+ +0 < icmp unreachable port_unreachable [0:0(0)]
+ +0 < . 1:1(0) ack 1 win 65535
+ +0 > R 1:1(0)
+ +0 close(3) = 0
+
+// Test 5: Socket with IPV6_PMTUDISC_INTERFACE ignores ICMPV6_PKT_TOOBIG
+// Socket configured with IPV6_PMTUDISC_INTERFACE (4) must not overwrite MTU
+// upon receiving ICMPV6_PKT_TOOBIG.
+ +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+ +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+ +0 bind(3, ..., ...) = 0
+ +0 listen(3, 1) = 0
+ +0 < S 0:0(0) win 65535 <mss 1440,sackOK,nop,nop,nop,wscale 8>
+ +0 > S. 0:0(0) ack 1 <...>
+ +0 < . 1:1(0) ack 1 win 257
+ +0 accept(3, ..., ...) = 4
+ +0 setsockopt(4, SOL_IPV6, IPV6_MTU_DISCOVER, [4], 4) = 0
+ +0 getsockopt(4, SOL_IPV6, IPV6_MTU, [1520], [4]) = 0
+ +0 write(4, ..., 1000) = 1000
+ +0 > P. 1:1001(1000) ack 1 <...>
+ +0 < icmp packet_too_big mtu 1280 [1:1001(1000)]
+ +0 getsockopt(4, SOL_IPV6, IPV6_MTU, [1520], [4]) = 0
+ +0 close(4) = 0
+ +0 close(3) = 0
--
2.56.0.679.gc527c65306-goog
next prev parent reply other threads:[~2026-11-17 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:35 [PATCH v1 net 0/8] tcp: Misc fixes for tcp_v[46]_err() Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 1/8] tcp: Don't accept ICMP for SND.NXT in TCP_SYN_SENT Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 2/8] tcp: Don't use inner IP TTL for IP_MINTTL in tcp_v4_err() Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 3/8] tcp: Don't bypass GTSM check for reqsk Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 4/8] tcp: Fix reqsk abort condition on ICMP errors Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 5/8] tcp: Check ip_sk_accept_pmtu() in tcp_v4_err() Kuniyuki Iwashima
2026-11-17 5:35 ` Kuniyuki Iwashima [this message]
2026-11-17 5:35 ` [PATCH v1 net 7/8] tcp: Pass inet_sdif() to __inet_lookup_established() " Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 8/8] tcp: Pass inet6_iif() to __inet6_lookup_established() in tcp_v6_err() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117053543.84032-7-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox