Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Leonard Lausen <leonard@lausen.nl>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
	Shuah Khan <shuah@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 1/2] ipv6: Honor suppress_prefixlength in fib6_lookup()
Date: Tue, 17 Nov 2026 18:12:55 +0200	[thread overview]
Message-ID: <20261117161255.GA878128@shredder> (raw)
In-Reply-To: <20261117110813.9894-3-leonard@lausen.nl>

On Tue, Nov 17, 2026 at 11:08:11AM +0000, Leonard Lausen wrote:
> When custom FIB rules are configured, fib6_lookup() performs the lookup
> via fib6_rule_action_alt() which calls fib6_table_lookup() and only
> populates the f6i, nh, fib6_flags and fib6_type fields of the FIB
> result. However, fib6_rule_suppress() only examines the rt6 field, which
> is only populated when the lookup is performed via one of the callers of
> fib6_rule_lookup() such as ip6_route_output(). As a result,
> fib6_lookup() ignores suppress_prefixlength.
> 
> This was not a problem for nftables until commit 1c32b24c234b
> ("netfilter: nft_fib_ipv6: switch to fib6_lookup") switched the FIB
> expression from ip6_route_lookup() / nf_ip6_route() to fib6_lookup().
> Since then, with a rule that suppresses the default route in the main
> table before looking up a VPN table (as commonly configured for
> WireGuard), the FIB expression returns the suppressed default route
> instead of the VPN route. Strict reverse path filtering then drops
> replies received over the VPN.
> 
> Fix by evaluating suppress_prefixlength against the prefix length of
> the FIB entry when the lookup is performed via fib6_lookup().
> 
> fib_rules_lookup() only invokes the suppress callback when the rule
> action returns 0. Unlike __fib6_rule_action(), fib6_rule_action_alt()
> returns 0 for reject routes and instead sets RTF_REJECT in the result.
> Do not suppress such routes so that they continue to terminate the
> lookup, as with ip6_route_output() and IPv4. Check the flags in the
> result rather than in the FIB entry so that blackhole nexthop objects
> are also covered.
> 
> suppress_ifgroup is not handled since fib6_table_lookup() does not
> perform multipath selection and the nexthop it returns might not be the
> one that is eventually used.

Simply deriving the 'ifgroup' from the first nexthop device would be
consistent with IPv4 and it only matters if someone is not putting all
the nexthop devices of a route in the same 'ifgroup', which would be
weird. I suspect 'suppress_ifgroup' is hardly used.

Anyway, this can be deferred to net-next.

> 
> Observed during WireGuard use and reproduced on unmodified v7.4-rc2,
> without instrumentation or error injection. Verified with namespace
> probes and nft_fib.sh on the rebuilt v7.4-rc2-based kernel.
> 
> Fixes: 1c32b24c234b ("netfilter: nft_fib_ipv6: switch to fib6_lookup")
> Link: https://github.com/firewalld/firewalld/issues/1600
> Signed-off-by: Leonard Lausen <leonard@lausen.nl>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

  reply	other threads:[~2026-11-17 16:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:08 [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Leonard Lausen
2026-11-17 11:08 ` [PATCH net v4 1/2] " Leonard Lausen
2026-11-17 16:12   ` Ido Schimmel [this message]
2026-11-17 11:08 ` [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression Leonard Lausen
2026-11-17 12:56 ` [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Pablo Neira Ayuso
2026-11-17 13:01   ` Leonard Lausen
2026-11-17 13:07     ` Pablo Neira Ayuso
2026-11-17 15:24       ` Ido Schimmel
2026-11-17 16:30         ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117161255.GA878128@shredder \
    --to=idosch@nvidia.com \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leonard@lausen.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox