Netdev List
 help / color / mirror / Atom feed
* [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
@ 2026-11-17 16:51 Dmitry Antipov
  2026-11-17 17:49 ` Joe Damato
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Antipov @ 2026-11-17 16:51 UTC (permalink / raw)
  To: Nikolay Aleksandrov, Ido Schimmel; +Cc: bridge, netdev, Dmitry Antipov

In store_backup_port(), prefer strchrnul() over strchr() to
avoid redundant call to strlen().

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
 net/bridge/br_sysfs_if.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
index 621d62a063d9..03205b3f465f 100644
--- a/net/bridge/br_sysfs_if.c
+++ b/net/bridge/br_sysfs_if.c
@@ -231,12 +231,12 @@ static ssize_t show_backup_port(struct net_bridge_port *p, char *buf)
 static int store_backup_port(struct net_bridge_port *p, char *buf)
 {
 	struct net_device *backup_dev = NULL;
-	char *nl = strchr(buf, '\n');
+	char *nl = strchrnul(buf, '\n');
 
-	if (nl)
+	if (*nl != '\0')
 		*nl = '\0';
 
-	if (strlen(buf) > 0) {
+	if (nl - buf > 0) {
 		backup_dev = __dev_get_by_name(dev_net(p->dev), buf);
 		if (!backup_dev)
 			return -ENOENT;
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17 17:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 16:51 [PATCH] net: bridge: avoid redundant strlen() in show_backup_port() Dmitry Antipov
2026-11-17 17:49 ` Joe Damato
2026-11-17 17:56   ` Ido Schimmel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox