Netdev List
 help / color / mirror / Atom feed
* [PATCH net v2 0/3] net: don't redirect decrypted skbs to ingress, psp time-wait validator
@ 2026-11-17 19:24 Todd Freed
  2026-11-17 19:24 ` [PATCH net v2 1/3] net/sched: act_mirred: don't send decrypted skbs from egress to ingress Todd Freed
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Todd Freed @ 2026-11-17 19:24 UTC (permalink / raw)
  To: netdev
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Daniel Zahka, Willem de Bruijn, Wei Wang,
	Jamal Hadi Salim, Jiri Pirko, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, John Fastabend,
	Stanislav Fomichev, Sabrina Dubroca, Boris Pismenny, bpf,
	linux-kernel

Three fixes that are relevant for the net-next series, "psp: introduce
socket-less associations". These were previously patches 6-8 of its v1:

  https://lore.kernel.org/netdev/20261111005533.6436-1-toddfreed@meta.com

The first two patches prevent sending decrypted skbs from egress to
ingress, since the meaning of skb->decrypted depends on the direction.
This affects the packets of kTLS and PSP device offload sockets.

The third patch makes psp_twsk_init() give a validator only to the
time-wait sockets of PSP connections with a Tx key, instead of to every
TCP time-wait socket. It has no effect today, but the net-next series
will rely on the presence of the validator to check if the socket has
an encryption offload.

Testing, on two hosts with mlx5 (ConnectX-7), with and without the
patches: an egress rule on a connection's flow sends its packets to the
device's ingress, with mirred (mirror and redirect) or bpf
(bpf_clone_redirect() and bpf_redirect() with BPF_F_INGRESS), for a PSP
device offload socket, a kTLS device offload socket and a plain TCP
socket.

Without the patches, the PSP and kTLS sockets' packets arrive on ingress
in all four cases. With them, none do: mirrored and cloned packets still
go out, encrypted by the device, and redirected ones are dropped. The
plain TCP socket's packets arrive on ingress in all four cases, with and
without the patches. The PSP and plain TCP cases give the same results
on netdevsim.

drivers/net psp.py and hw/tls_hw_offload.py pass, with and without the
patches, as does tc-testing mirred.json on netdevsim (39 pass, 7 skipped
by their dependsOn probes). Each patch builds without warnings (gcc and
clang, allmodconfig, W=1).

v2 was re-tested as above, plus bpf selftests  lwt_redirect, lwt_reroute
and lwt_misc

v2:
- Cc: stable on patches 1 and 2 (Jamal)
- patch 2: also clear tc_at_ingress before running an LWT xmit program.
  Sashiko found this in its review of the same patch in the net-next
  series v1:
  https://lore.kernel.org/netdev/179471270091.2199510.4320994626979041884@kernel.org
- drop commit message references to the net-next series (Daniel)
- rebased on net/main

v1: https://lore.kernel.org/netdev/20261113185553.171059-1-toddfreed@meta.com

Todd Freed (3):
  net/sched: act_mirred: don't send decrypted skbs from egress to
    ingress
  bpf: don't redirect decrypted skbs from egress to ingress
  psp: only give time-wait sockets of PSP connections a validator

 net/core/filter.c      | 10 ++++++++++
 net/core/lwt_bpf.c     |  8 ++++++++
 net/psp/psp_sock.c     |  6 ++++--
 net/sched/act_mirred.c |  6 ++++++
 4 files changed, 28 insertions(+), 2 deletions(-)


base-commit: 5e9b2ad9b8384cd3c417cd5e2c3bc7eee4a72791
-- 
2.53.1-Meta

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17 19:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 19:24 [PATCH net v2 0/3] net: don't redirect decrypted skbs to ingress, psp time-wait validator Todd Freed
2026-11-17 19:24 ` [PATCH net v2 1/3] net/sched: act_mirred: don't send decrypted skbs from egress to ingress Todd Freed
2026-11-17 19:24 ` [PATCH net v2 2/3] bpf: don't redirect " Todd Freed
2026-11-17 19:24 ` [PATCH net v2 3/3] psp: only give time-wait sockets of PSP connections a validator Todd Freed

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox