Netdev List
 help / color / mirror / Atom feed
* [RFC] net: ena: use tx-push-buf-len while tx-push is off
@ 2026-11-18  4:12 evostrov
  0 siblings, 0 replies; only message in thread
From: evostrov @ 2026-11-18  4:12 UTC (permalink / raw)
  To: netdev
  Cc: Evgeny Ostrovsky, Jakub Kicinski, David Arinzon, Shay Agroskin,
	Arthur Kiyanovski, Gal Pressman, Michal Kubiak, Paolo Abeni,
	Eric Dumazet, Kuniyuki Iwashima, Shai Brandes, linux-doc

From: Evgeny Ostrovsky <evostrov@amazon.com>

We want to confirm one point before sending the driver patches:
we would like to allow setting the tx-push-buf-len when tx-push is off,
but the name is problematic so we are not sure what will be the correct way
to achieve this.

Current state:
- ethtool has tx-push and tx-push-buf-len.
- tx-push on means the driver writes the packet header into device memory.
- tx-push-buf-len is the length of that header.
- Today the driver uses tx-push-buf-len only when tx-push is on.

We are adding a new LLQ mode to ENA: pull mode.
- In pull mode the header stays in host memory and the device reads it.
- So tx-push is off.
- We still need to tell the device how many header bytes to pull.
- We want to use tx-push-buf-len for this, with tx-push off.

ENA is the only in-tree driver that uses tx-push-buf-len, so this does
not change any other driver.

Example on a device that supports pull mode:

ethtool -G <dev> tx-push off tx-push-buf-len 224
ethtool -g <dev> -> TX Push: off, TX push buff len: 224

The core already allows this. net/ethtool/rings.c checks only the
capability bit and that the length is not above the max. It does not tie
tx-push-buf-len to tx-push.

In a 2023 review Gal Pressman suggested using tx-push-buf-len only when
tx-push is on. That was never added as code or written as a rule.
Link: https://lore.kernel.org/netdev/30cb3990-80ce-ca07-6d73-cdc00d0ad7b8@nvidia.com/

Request: Please confirm this is fine or if not can you please suggest another
way of achieving the pull mode len setup functionality.

Thank you

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-18  4:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  4:12 [RFC] net: ena: use tx-push-buf-len while tx-push is off evostrov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox