netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 0/6] bonding: 3ad: Support independent control with LAG offload
@ 2026-11-18  8:34 Ido Schimmel
  2026-11-18  8:34 ` [PATCH net-next 1/6] net: Add Rx enabled state to LAG lower state information Ido Schimmel
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Ido Schimmel @ 2026-11-18  8:34 UTC (permalink / raw)
  To: netdev
  Cc: davem, kuba, pabeni, edumazet, jv, andrew+netdev, petrm,
	sridhar.samudrala, jiri, horms, shuah, linux-kselftest, razor,
	Ido Schimmel

When coupled control is disabled (i.e., independent control is enabled),
an 802.3ad port can be in COLLECTING state where it is enabled for
collection, but not for distribution. This is useful in deployments that
want to avoid packet loss caused by a port starting to distribute before
its partner starts collecting.

Drivers that offload LAG are not aware of this Rx-only state since the
LAG lower state information only indicates whether the port is enabled
for transmission and the bond does not notify about Rx state changes.
Instead, these drivers enable or disable both collection and
distribution on the port according to its Tx state. As a result, packets
received by a port in COLLECTING state are dropped by the hardware.

In addition, a port that enters COLLECTING state advertises the
Collecting bit in its LACPDUs before offloading drivers are notified
about the Rx state change. The partner can therefore start distributing
packets to the port before collection is enabled, which defeats the
purpose of independent control.

Patch #1 adds an Rx enabled state to the LAG lower state information and
sets it according to the existing Tx enabled state.

Patch #2 sets this state in the bond driver according to the port's Rx
state and notifies about Rx state changes. The team driver keeps setting
it according to the Tx state.

Patch #3 changes mlxsw to enable collection independently of
distribution. Other drivers keep using the Tx enabled state, so their
behavior does not change.

Patch #4 adds a selftest for the Rx notifications (i.e., entering /
leaving COLLECTING state).

Patch #5 masks the Collecting bit in transmitted LACPDUs until the
notification about the Rx state change has been delivered.

Patch #6 adds a selftest for the previous patch.

Ido Schimmel (6):
  net: Add Rx enabled state to LAG lower state information
  bonding: 3ad: Notify Rx state changes
  mlxsw: Enable LAG collector independently of distributor
  selftests: bonding: Test notifications in COLLECTING state
  bonding: 3ad: Advertise Collecting only after collection is enabled
  selftests: bonding: Test that Collecting is advertised after
    notification

 drivers/net/bonding/bond_3ad.c                | 24 ++++-
 drivers/net/bonding/bond_main.c               |  4 +
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 15 +++
 drivers/net/net_failover.c                    |  1 +
 drivers/net/team/team_core.c                  |  1 +
 include/linux/netdevice.h                     |  3 +-
 include/net/bonding.h                         | 25 ++++-
 .../bonding/bond_lacp_independent_control.sh  | 94 ++++++++++++++++++-
 8 files changed, 159 insertions(+), 8 deletions(-)

-- 
2.56.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-18  8:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  8:34 [PATCH net-next 0/6] bonding: 3ad: Support independent control with LAG offload Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 1/6] net: Add Rx enabled state to LAG lower state information Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 2/6] bonding: 3ad: Notify Rx state changes Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 3/6] mlxsw: Enable LAG collector independently of distributor Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 4/6] selftests: bonding: Test notifications in COLLECTING state Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 5/6] bonding: 3ad: Advertise Collecting only after collection is enabled Ido Schimmel
2026-11-18  8:34 ` [PATCH net-next 6/6] selftests: bonding: Test that Collecting is advertised after notification Ido Schimmel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).