From: Eric Dumazet <edumazet@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neal Cardwell <ncardwell@google.com>
Cc: Kuniyuki Iwashima <kuniyu@google.com>,
Simon Horman <horms@kernel.org>,
Flavius-Romeo Mazilu <flavius.mazilu@stud.acs.upb.ro>,
Michael Tuexen <tuexen@fh-muenster.de>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@kernel.org>
Subject: [PATCH net-next 0/2] tcp: do not accept ACK of our ISS on active opens
Date: Wed, 18 Nov 2026 18:26:52 +0100 [thread overview]
Message-ID: <20261118172654.1267071-1-edumazet@kernel.org> (raw)
Michael Tuexen asked on the tcpm list whether, after a completed
handshake, a segment with SEG.ACK == ISS is a duplicate ACK or a ghost
ACK [1]. Flavius-Romeo Mazilu noted that Linux gives a different answer
on each side of the connection [2]: passive opens send a challenge ACK,
active opens silently accept the segment.
The first patch makes active opens (including Fast Open and
simultaneous opens) behave like passive ones, without changing
the value of tcpi_bytes_acked seen by user space and BPF.
The second patch adds packetdrill tests for the four ways
a socket can be established.
This closes one extra acceptable ACK value on active opens,
so this is targeting net-next.
[1] https://mailarchive.ietf.org/arch/msg/tcpm/ZbjDTFQSHeKSVHAToyAnKBr3TpU/
[2] https://mailarchive.ietf.org/arch/msg/tcpm/ym6lb-UkrW2298LRnTLxCysoo0g/
Eric Dumazet (2):
tcp: do not accept ACK of our ISS on active opens
selftests/net: packetdrill: add tests for ACK of ISS
.../networking/net_cachelines/tcp_sock.rst | 1 +
include/linux/tcp.h | 3 +-
net/ipv4/tcp.c | 1 +
net/ipv4/tcp_input.c | 10 +++-
.../tcp_rfc5961_ack-iss-client.pkt | 46 +++++++++++++++++++
.../tcp_rfc5961_ack-iss-fastopen-client.pkt | 40 ++++++++++++++++
.../tcp_rfc5961_ack-iss-server.pkt | 45 ++++++++++++++++++
.../tcp_rfc5961_ack-iss-simultaneous-open.pkt | 42 +++++++++++++++++
8 files changed, 185 insertions(+), 3 deletions(-)
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-client.pkt
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-fastopen-client.pkt
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-server.pkt
create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-simultaneous-open.pkt
base-commit: d6816d9a93b66a12bf01e10037e377f3333ad6cc
--
2.53.0
next reply other threads:[~2026-11-18 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 17:26 Eric Dumazet [this message]
2026-11-18 17:26 ` [PATCH net-next 1/2] tcp: do not accept ACK of our ISS on active opens Eric Dumazet
2026-11-18 17:26 ` [PATCH net-next 2/2] selftests/net: packetdrill: add tests for ACK of ISS Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118172654.1267071-1-edumazet@kernel.org \
--to=edumazet@kernel.org \
--cc=davem@davemloft.net \
--cc=flavius.mazilu@stud.acs.upb.ro \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tuexen@fh-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox