Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next 0/2] tcp: do not accept ACK of our ISS on active opens
@ 2026-11-18 17:26 Eric Dumazet
  2026-11-18 17:26 ` [PATCH net-next 1/2] " Eric Dumazet
  2026-11-18 17:26 ` [PATCH net-next 2/2] selftests/net: packetdrill: add tests for ACK of ISS Eric Dumazet
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2026-11-18 17:26 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski, Paolo Abeni, Neal Cardwell
  Cc: Kuniyuki Iwashima, Simon Horman, Flavius-Romeo Mazilu,
	Michael Tuexen, netdev, Eric Dumazet

Michael Tuexen asked on the tcpm list whether, after a completed
handshake, a segment with SEG.ACK == ISS is a duplicate ACK or a ghost
ACK [1]. Flavius-Romeo Mazilu noted that Linux gives a different answer
on each side of the connection [2]: passive opens send a challenge ACK,
active opens silently accept the segment.

The first patch makes active opens (including Fast Open and
simultaneous opens) behave like passive ones, without changing
the value of tcpi_bytes_acked seen by user space and BPF.

The second patch adds packetdrill tests for the four ways
a socket can be established.

This closes one extra acceptable ACK value on active opens,
so this is targeting net-next.

[1] https://mailarchive.ietf.org/arch/msg/tcpm/ZbjDTFQSHeKSVHAToyAnKBr3TpU/
[2] https://mailarchive.ietf.org/arch/msg/tcpm/ym6lb-UkrW2298LRnTLxCysoo0g/

Eric Dumazet (2):
  tcp: do not accept ACK of our ISS on active opens
  selftests/net: packetdrill: add tests for ACK of ISS

 .../networking/net_cachelines/tcp_sock.rst    |  1 +
 include/linux/tcp.h                           |  3 +-
 net/ipv4/tcp.c                                |  1 +
 net/ipv4/tcp_input.c                          | 10 +++-
 .../tcp_rfc5961_ack-iss-client.pkt            | 46 +++++++++++++++++++
 .../tcp_rfc5961_ack-iss-fastopen-client.pkt   | 40 ++++++++++++++++
 .../tcp_rfc5961_ack-iss-server.pkt            | 45 ++++++++++++++++++
 .../tcp_rfc5961_ack-iss-simultaneous-open.pkt | 42 +++++++++++++++++
 8 files changed, 185 insertions(+), 3 deletions(-)
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-client.pkt
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-fastopen-client.pkt
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-server.pkt
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-iss-simultaneous-open.pkt


base-commit: d6816d9a93b66a12bf01e10037e377f3333ad6cc
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18 17:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 17:26 [PATCH net-next 0/2] tcp: do not accept ACK of our ISS on active opens Eric Dumazet
2026-11-18 17:26 ` [PATCH net-next 1/2] " Eric Dumazet
2026-11-18 17:26 ` [PATCH net-next 2/2] selftests/net: packetdrill: add tests for ACK of ISS Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox