Netdev List
 help / color / mirror / Atom feed
* [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter
@ 2026-11-19 17:57 Kyle Hendry via B4 Relay
  2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
                   ` (6 more replies)
  0 siblings, 7 replies; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

On the rzn1, there are two resets for the mii converter in the system
controller. If they are not cleared by the bootloader then the kernel needs
to do it. 

To handle this, I've added a reset controller interface to the clock
driver so the miic driver can deassert them.

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
Kyle Hendry (6):
      dt-bindings: clock: r9a06g032-sysctrl: Document reset cells
      clk: renesas: r9a06g032: Add reset controller
      ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node
      dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets
      net: pcs: rzn1-miic: Add resets to rzn1 info structure
      ARM: dts: renesas: r9a06g032: Add resets to mii converter

 .../bindings/clock/renesas,r9a06g032-sysctrl.yaml  |  3 +
 .../bindings/net/pcs/renesas,rzn1-miic.yaml        | 36 ++++++++----
 arch/arm/boot/dts/renesas/r9a06g032.dtsi           |  4 ++
 drivers/clk/renesas/r9a06g032-clocks.c             | 64 ++++++++++++++++++++++
 drivers/net/pcs/pcs-rzn1-miic.c                    |  7 +++
 include/dt-bindings/clock/r9a06g032-sysctrl.h      |  3 +
 6 files changed, 106 insertions(+), 11 deletions(-)
---
base-commit: 662377fd1bb1d7cf4e97d312255fed868f56342d
change-id: 20261027-rzn1-miic-resets-8308515aa2c0

Best regards,
-- 
Kyle Hendry <khendry@reliablecontrols.com>



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-20  9:23   ` Wolfram Sang
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

Update the rzn1 system controller to indicate it can be a reset controller
and add defines for miic resets

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml | 3 +++
 include/dt-bindings/clock/r9a06g032-sysctrl.h                          | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
index 26d94cedc871..c552b78c9d43 100644
--- a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
@@ -36,6 +36,9 @@ properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    const: 1
+
   '#power-domain-cells':
     const: 0
 
diff --git a/include/dt-bindings/clock/r9a06g032-sysctrl.h b/include/dt-bindings/clock/r9a06g032-sysctrl.h
index d9d7b8b4f426..e3059c50f7c3 100644
--- a/include/dt-bindings/clock/r9a06g032-sysctrl.h
+++ b/include/dt-bindings/clock/r9a06g032-sysctrl.h
@@ -146,4 +146,7 @@
 #define R9A06G032_CLK_UART6		152
 #define R9A06G032_CLK_UART7		153
 
+#define R9A06G032_RST_TS		1
+#define R9A06G032_RST_MIIC		2
+
 #endif /* __DT_BINDINGS_R9A06G032_SYSCTRL_H__ */

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
  2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-20  9:30   ` Wolfram Sang
                     ` (3 more replies)
  2026-11-19 17:57 ` [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node Kyle Hendry via B4 Relay
                   ` (4 subsequent siblings)
  6 siblings, 4 replies; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

The rzn1 system controller has two resets that need to be cleared for the
mii converter to work. They are not directly associated with any clocks
so they need a reset controller to set them.

They are documented in the PWRCTRL_SWITCHCTRL (0x4000C188) register as:

Bit 3: RSTN_CLK25 - Active low Reset for Timestamp signal selection logic
Bit 4: RSTN_ETH - Active low Reset for RGMII/RMII Converter (50 MHz).

Add a reset controller and add resets for those bits.

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 drivers/clk/renesas/r9a06g032-clocks.c | 64 ++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
index 3df3f2b2c6de..547e8d82f1cf 100644
--- a/drivers/clk/renesas/r9a06g032-clocks.c
+++ b/drivers/clk/renesas/r9a06g032-clocks.c
@@ -21,6 +21,7 @@
 #include <linux/pm_clock.h>
 #include <linux/pm_domain.h>
 #include <linux/reboot.h>
+#include <linux/reset-controller.h>
 #include <linux/slab.h>
 #include <linux/soc/renesas/r9a06g032-sysctrl.h>
 #include <linux/spinlock.h>
@@ -675,6 +676,11 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = {
 		RB(0xec, 16), RB(0xec, 17), RB(0xec, 18), RB(0xec, 19)),
 };
 
+static const struct regbit r9a06g032_resets[] = {
+	RB(0x188, 3),
+	RB(0x188, 4),
+};
+
 struct r9a06g032_priv {
 	struct clk_onecell_data data;
 	spinlock_t lock; /* protects concurrent access to gates */
@@ -1307,6 +1313,56 @@ static void __init r9a06g032_init_h2mode(struct r9a06g032_priv *clocks)
 	writel(usb, clocks->reg + R9A06G032_SYSCTRL_USB);
 }
 
+
+#define rcdev_to_priv(x)	container_of(x, struct r9a06g032_priv, rcdev)
+
+static int r9a06g032_reset_set(struct reset_controller_dev *rcdev,
+				  const char *func, bool set, unsigned long id)
+{
+	struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
+	unsigned long flags;
+
+	spin_lock_irqsave(&priv->lock, flags);
+	clk_rdesc_set(priv, r9a06g032_resets[id], set);
+	spin_unlock_irqrestore(&priv->lock, flags);
+
+	return 0;
+}
+
+static int r9a06g032_reset(struct reset_controller_dev *rcdev,
+			  unsigned long id)
+{
+	r9a06g032_reset_set(rcdev, "reset", true, id);
+	udelay(5);
+	return r9a06g032_reset_set(rcdev, NULL, false, id);
+}
+
+static int r9a06g032_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
+{
+	return r9a06g032_reset_set(rcdev, "assert", false, id);
+}
+
+static int r9a06g032_reset_deassert(struct reset_controller_dev *rcdev,
+			     unsigned long id)
+{
+	return r9a06g032_reset_set(rcdev, "deassert", true, id);
+}
+
+static int r9a06g032_reset_status(struct reset_controller_dev *rcdev,
+			   unsigned long id)
+{
+	struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
+
+	return clk_rdesc_get(priv, r9a06g032_resets[id]);
+}
+
+static const struct reset_control_ops r9a06g032_reset_ops = {
+	.reset = r9a06g032_reset,
+	.assert = r9a06g032_reset_assert,
+	.deassert = r9a06g032_reset_deassert,
+	.status = r9a06g032_reset_status,
+};
+
 static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -1404,6 +1460,14 @@ static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
 	if (error)
 		dev_err(dev, "Failed to populate children (%d)\n", error);
 
+	clocks->rcdev.ops = &r9a06g032_reset_ops;
+	clocks->rcdev.of_node = np;
+	clocks->rcdev.of_reset_n_cells = 1;
+	clocks->rcdev.nr_resets = ARRAY_SIZE(r9a06g032_resets);
+	error =  devm_reset_controller_register(dev, &clocks->rcdev);
+	if (error)
+		return error;
+
 	return 0;
 }
 

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
  2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-20  9:32   ` Wolfram Sang
  2026-11-19 17:57 ` [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets Kyle Hendry via B4 Relay
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

Update the rzn1 system controller node with cells for the reset controller

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 arch/arm/boot/dts/renesas/r9a06g032.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/renesas/r9a06g032.dtsi b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
index 5455dccfbdd0..f2bf087f7ad2 100644
--- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
@@ -146,6 +146,7 @@ sysctrl: system-controller@4000c000 {
 			compatible = "renesas,r9a06g032-sysctrl";
 			reg = <0x4000c000 0x1000>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 			#power-domain-cells = <0>;
 
 			clocks = <&ext_mclk>, <&ext_rtc_clk>,

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
                   ` (2 preceding siblings ...)
  2026-11-19 17:57 ` [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-20 11:49   ` Wolfram Sang
  2026-11-19 17:57 ` [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure Kyle Hendry via B4 Relay
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

On the rzn1, there are two resets for the miic. Add documentation for them.

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 .../bindings/net/pcs/renesas,rzn1-miic.yaml        | 36 +++++++++++++++-------
 1 file changed, 25 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml b/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml
index f9d39114e667..d0d820f86da6 100644
--- a/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml
+++ b/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml
@@ -51,14 +51,12 @@ properties:
       - const: hclk
 
   resets:
-    items:
-      - description: Converter register reset
-      - description: Converter reset
+    minItems: 2
+    maxItems: 2
 
   reset-names:
-    items:
-      - const: rst
-      - const: crst
+    minItems: 2
+    maxItems: 2
 
   renesas,miic-switch-portin:
     description: MII Switch PORTIN configuration. This value should use one of
@@ -109,8 +107,14 @@ allOf:
       properties:
         renesas,miic-switch-portin:
           enum: [1, 2]
-        resets: false
-        reset-names: false
+        resets:
+          items:
+            - description: Timestamp selector reset
+            - description: Converter reset
+        reset-names:
+          items:
+            - const: rst_ts
+            - const: rst_miic
       patternProperties:
         "^mii-conv@[0-5]$":
           properties:
@@ -161,9 +165,14 @@ allOf:
       properties:
         renesas,miic-switch-portin:
           const: 0
-      required:
-        - resets
-        - reset-names
+        resets:
+          items:
+            - description: Converter register reset
+            - description: Converter reset
+        reset-names:
+          items:
+            - const: rst
+            - const: crst
       patternProperties:
         "^mii-conv@[0-5]$":
           properties:
@@ -210,6 +219,8 @@ required:
   - reg
   - clocks
   - clock-names
+  - resets
+  - reset-names
   - power-domains
 
 additionalProperties: false
@@ -229,6 +240,9 @@ examples:
               <&sysctrl R9A06G032_CLK_RMII_REF>,
               <&sysctrl R9A06G032_HCLK_SWITCH_RG>;
       clock-names = "mii_ref", "rgmii_ref", "rmii_ref", "hclk";
+      resets = <&sysctrl R9A06G032_RST_TS>,
+              <&sysctrl R9A06G032_RST_MIIC>;
+      reset-names = "rst_ts", "rst_miic";
       renesas,miic-switch-portin = <MIIC_GMAC2_PORT>;
       power-domains = <&sysctrl>;
 

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
                   ` (3 preceding siblings ...)
  2026-11-19 17:57 ` [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-19 17:57 ` [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter Kyle Hendry via B4 Relay
  2026-11-19 22:02 ` [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for " Jakub Kicinski
  6 siblings, 0 replies; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

Update the rzn1 info structure to include the resets that the driver needs
to deassert

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 drivers/net/pcs/pcs-rzn1-miic.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index f8bafce26bf1..38164502c08c 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -128,6 +128,11 @@ static const char * const index_to_string[] = {
 	"CONV5",
 };
 
+static const char * const rzn1_reset_ids[] = {
+	"rst_ts",
+	"rst_miic",
+};
+
 static struct modctrl_match rzt2h_modctrl_match_table[] = {
 	{0x0, {ETHSS_GMAC0_PORT, ETHSS_ETHSW_PORT0, ETHSS_ETHSW_PORT1,
 	       ETHSS_ETHSW_PORT2, ETHSS_GMAC1_PORT}},
@@ -855,6 +860,8 @@ static struct miic_of_data rzn1_miic_of_data = {
 	.miic_port_start = 1,
 	.miic_port_last = 5,
 	.sw_mode_mask = GENMASK(4, 0),
+	.reset_ids = rzn1_reset_ids,
+	.reset_count = ARRAY_SIZE(rzn1_reset_ids),
 	.init_unlock_lock_regs = true,
 	.miic_write = miic_reg_writel_unlocked,
 	.type = MIIC_TYPE_RZN1,

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
                   ` (4 preceding siblings ...)
  2026-11-19 17:57 ` [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure Kyle Hendry via B4 Relay
@ 2026-11-19 17:57 ` Kyle Hendry via B4 Relay
  2026-11-20  9:34   ` Wolfram Sang
  2026-11-19 22:02 ` [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for " Jakub Kicinski
  6 siblings, 1 reply; 18+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-11-19 17:57 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev,
	Kyle Hendry

From: Kyle Hendry <khendry@reliablecontrols.com>

Add references to the resets in the system driver that the miic needs

Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
 arch/arm/boot/dts/renesas/r9a06g032.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/renesas/r9a06g032.dtsi b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
index f2bf087f7ad2..0a538d922125 100644
--- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
@@ -463,6 +463,9 @@ eth_miic: eth-miic@44030000 {
 				 <&sysctrl R9A06G032_CLK_RMII_REF>,
 				 <&sysctrl R9A06G032_HCLK_SWITCH_RG>;
 			clock-names = "mii_ref", "rgmii_ref", "rmii_ref", "hclk";
+			resets = <&sysctrl R9A06G032_RST_TS>,
+				 <&sysctrl R9A06G032_RST_MIIC>;
+			reset-names = "rst_ts", "rst_miic";
 			power-domains = <&sysctrl>;
 			status = "disabled";
 

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter
  2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
                   ` (5 preceding siblings ...)
  2026-11-19 17:57 ` [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter Kyle Hendry via B4 Relay
@ 2026-11-19 22:02 ` Jakub Kicinski
  6 siblings, 0 replies; 18+ messages in thread
From: Jakub Kicinski @ 2026-11-19 22:02 UTC (permalink / raw)
  To: Kyle Hendry via B4 Relay
  Cc: khendry, Geert Uytterhoeven, Stephen Boyd, Brian Masney,
	Jerome Brunet, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Magnus Damm, Fabrizio Castro, Philipp Zabel,
	Clément Léger, Andrew Lunn, David S. Miller,
	Eric Dumazet, Paolo Abeni, Lad Prabhakar, Andrew Lunn,
	Heiner Kallweit, Russell King, linux-renesas-soc, linux-clk,
	devicetree, linux-kernel, netdev

On Thu, 19 Nov 2026 09:57:42 -0800 Kyle Hendry via B4 Relay wrote:
> On the rzn1, there are two resets for the mii converter in the system
> controller. If they are not cleared by the bootloader then the kernel needs
> to do it. 

You need to split this up by subsystem, the series as posted doesn't
seem to build for us. Please send patches 4 and 5 as a separate mini
series and tag it for net-next. Please wait until tomorrow (24h 
from this posting) per netdev subsystem guide.

Thanks!

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells
  2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
@ 2026-11-20  9:23   ` Wolfram Sang
  2026-11-20  9:51     ` Philipp Zabel
  0 siblings, 1 reply; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20  9:23 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

Hi Kyle,

thank you for this series!

>  
> +  '#reset-cells':
> +    const: 1
> +

Maybe add the new property to the example below, too?

> diff --git a/include/dt-bindings/clock/r9a06g032-sysctrl.h b/include/dt-bindings/clock/r9a06g032-sysctrl.h
> index d9d7b8b4f426..e3059c50f7c3 100644
> --- a/include/dt-bindings/clock/r9a06g032-sysctrl.h
> +++ b/include/dt-bindings/clock/r9a06g032-sysctrl.h
> @@ -146,4 +146,7 @@
>  #define R9A06G032_CLK_UART6		152
>  #define R9A06G032_CLK_UART7		153
>  
> +#define R9A06G032_RST_TS		1
> +#define R9A06G032_RST_MIIC		2

I didn't find any listing of the resets in the RZN1 docs, so coming up
with arbitrary numbers as we need them seems okay to me.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
@ 2026-11-20  9:30   ` Wolfram Sang
  2026-11-20 10:00   ` Philipp Zabel
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20  9:30 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

On Thu, Nov 19, 2026 at 09:57:44AM -0800, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
> 
> The rzn1 system controller has two resets that need to be cleared for the
> mii converter to work. They are not directly associated with any clocks
> so they need a reset controller to set them.
> 
> They are documented in the PWRCTRL_SWITCHCTRL (0x4000C188) register as:
> 
> Bit 3: RSTN_CLK25 - Active low Reset for Timestamp signal selection logic
> Bit 4: RSTN_ETH - Active low Reset for RGMII/RMII Converter (50 MHz).
> 
> Add a reset controller and add resets for those bits.
> 
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>

General approach looks good to me, just some minor comments...

> +static const struct regbit r9a06g032_resets[] = {
> +	RB(0x188, 3),
> +	RB(0x188, 4),
> +};

Please add the DT name of the reset as a comment after each line.

 +	RB(0x188, 3),	/* RST_TS */

or similar.

> +static int r9a06g032_reset_set(struct reset_controller_dev *rcdev,
> +				  const char *func, bool set, unsigned long id)
> +{

*func was likely debug help and is unused now and can go.

> +	struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&priv->lock, flags);
> +	clk_rdesc_set(priv, r9a06g032_resets[id], set);
> +	spin_unlock_irqrestore(&priv->lock, flags);
> +
> +	return 0;
> +}
> +
> +static int r9a06g032_reset(struct reset_controller_dev *rcdev,
> +			  unsigned long id)
> +{
> +	r9a06g032_reset_set(rcdev, "reset", true, id);
> +	udelay(5);

For future reference, please add a comment pointing to chapter in the
docs where it is saying 5us is needed.

Rest looks good!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node
  2026-11-19 17:57 ` [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node Kyle Hendry via B4 Relay
@ 2026-11-20  9:32   ` Wolfram Sang
  0 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20  9:32 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

On Thu, Nov 19, 2026 at 09:57:45AM -0800, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
> 
> Update the rzn1 system controller node with cells for the reset controller
> 
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>

I'll leave the final decision for Geert, but I think this can be merged
with patch 6. But in general:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter
  2026-11-19 17:57 ` [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter Kyle Hendry via B4 Relay
@ 2026-11-20  9:34   ` Wolfram Sang
  0 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20  9:34 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Thu, Nov 19, 2026 at 09:57:48AM -0800, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
> 
> Add references to the resets in the system driver that the miic needs
> 
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells
  2026-11-20  9:23   ` Wolfram Sang
@ 2026-11-20  9:51     ` Philipp Zabel
  2026-11-20 11:11       ` Wolfram Sang
  0 siblings, 1 reply; 18+ messages in thread
From: Philipp Zabel @ 2026-11-20  9:51 UTC (permalink / raw)
  To: Wolfram Sang, khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Clément Léger, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Lad Prabhakar, Andrew Lunn, Heiner Kallweit, Russell King,
	linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev

On Fr, 2026-11-20 at 10:23 +0100, Wolfram Sang wrote:
> Hi Kyle,
> 
> thank you for this series!
> 
> >  
> > +  '#reset-cells':
> > +    const: 1
> > +
> 
> Maybe add the new property to the example below, too?
> 
> > diff --git a/include/dt-bindings/clock/r9a06g032-sysctrl.h b/include/dt-bindings/clock/r9a06g032-sysctrl.h
> > index d9d7b8b4f426..e3059c50f7c3 100644
> > --- a/include/dt-bindings/clock/r9a06g032-sysctrl.h
> > +++ b/include/dt-bindings/clock/r9a06g032-sysctrl.h
> > @@ -146,4 +146,7 @@
> >  #define R9A06G032_CLK_UART6		152
> >  #define R9A06G032_CLK_UART7		153
> >  
> > +#define R9A06G032_RST_TS		1
> > +#define R9A06G032_RST_MIIC		2
> 
> I didn't find any listing of the resets in the RZN1 docs, so coming up
> with arbitrary numbers as we need them seems okay to me.

Why aren't we starting at 0?

regards
Philipp

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
  2026-11-20  9:30   ` Wolfram Sang
@ 2026-11-20 10:00   ` Philipp Zabel
  2026-11-20 11:47   ` Wolfram Sang
  2026-11-20 23:25   ` kernel test robot
  3 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2026-11-20 10:00 UTC (permalink / raw)
  To: khendry, Geert Uytterhoeven, Stephen Boyd, Brian Masney,
	Jerome Brunet, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Magnus Damm, Fabrizio Castro, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: linux-renesas-soc, linux-clk, devicetree, linux-kernel, netdev

On Do, 2026-11-19 at 09:57 -0800, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
> 
> The rzn1 system controller has two resets that need to be cleared for the
> mii converter to work. They are not directly associated with any clocks
> so they need a reset controller to set them.
> 
> They are documented in the PWRCTRL_SWITCHCTRL (0x4000C188) register as:
> 
> Bit 3: RSTN_CLK25 - Active low Reset for Timestamp signal selection logic
> Bit 4: RSTN_ETH - Active low Reset for RGMII/RMII Converter (50 MHz).
> 
> Add a reset controller and add resets for those bits.
> 
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
> ---
>  drivers/clk/renesas/r9a06g032-clocks.c | 64 ++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
> 
> diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
> index 3df3f2b2c6de..547e8d82f1cf 100644
> --- a/drivers/clk/renesas/r9a06g032-clocks.c
> +++ b/drivers/clk/renesas/r9a06g032-clocks.c
> @@ -21,6 +21,7 @@
>  #include <linux/pm_clock.h>
>  #include <linux/pm_domain.h>
>  #include <linux/reboot.h>
> +#include <linux/reset-controller.h>
>  #include <linux/slab.h>
>  #include <linux/soc/renesas/r9a06g032-sysctrl.h>
>  #include <linux/spinlock.h>
> @@ -675,6 +676,11 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = {
>  		RB(0xec, 16), RB(0xec, 17), RB(0xec, 18), RB(0xec, 19)),
>  };
>  
> +static const struct regbit r9a06g032_resets[] = {
> +	RB(0x188, 3),
> +	RB(0x188, 4),

I suggest to use designated initializers:

	[R9A06G032_RST_TS] = RB(0x188, 3),
	[R9A06G032_RST_MIIC] = RB(0x188, 4),

to document the association and make sure there are no off-by-one
errors.

> +};
> +
>  struct r9a06g032_priv {
>  	struct clk_onecell_data data;
>  	spinlock_t lock; /* protects concurrent access to gates */
> @@ -1307,6 +1313,56 @@ static void __init r9a06g032_init_h2mode(struct r9a06g032_priv *clocks)
>  	writel(usb, clocks->reg + R9A06G032_SYSCTRL_USB);
>  }
>  
> +
> +#define rcdev_to_priv(x)	container_of(x, struct r9a06g032_priv, rcdev)

I'd use a static inline function for this.

> +
> +static int r9a06g032_reset_set(struct reset_controller_dev *rcdev,
> +				  const char *func, bool set, unsigned long id)
> +{
> +	struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&priv->lock, flags);
> +	clk_rdesc_set(priv, r9a06g032_resets[id], set);
> +	spin_unlock_irqrestore(&priv->lock, flags);
> +
> +	return 0;
> +}
> +
> +static int r9a06g032_reset(struct reset_controller_dev *rcdev,
> +			  unsigned long id)
> +{
> +	r9a06g032_reset_set(rcdev, "reset", true, id);
> +	udelay(5);
> +	return r9a06g032_reset_set(rcdev, NULL, false, id);
> +}

Please don't implement the reset op unless really needed for
compatibility with actual, self-clearing reset controllers.

If it is needed, please explain why. If so, is this delay enough for
both resets? Is it enough for any other resets this reset controller
driver may support in the future?

> +
> +static int r9a06g032_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
> +{
> +	return r9a06g032_reset_set(rcdev, "assert", false, id);
> +}
> +
> +static int r9a06g032_reset_deassert(struct reset_controller_dev *rcdev,
> +			     unsigned long id)
> +{
> +	return r9a06g032_reset_set(rcdev, "deassert", true, id);
> +}
> +
> +static int r9a06g032_reset_status(struct reset_controller_dev *rcdev,
> +			   unsigned long id)
> +{
> +	struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
> +
> +	return clk_rdesc_get(priv, r9a06g032_resets[id]);
> +}
> +
> +static const struct reset_control_ops r9a06g032_reset_ops = {
> +	.reset = r9a06g032_reset,
> +	.assert = r9a06g032_reset_assert,
> +	.deassert = r9a06g032_reset_deassert,
> +	.status = r9a06g032_reset_status,
> +};
> +
>  static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> @@ -1404,6 +1460,14 @@ static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
>  	if (error)
>  		dev_err(dev, "Failed to populate children (%d)\n", error);
>  
> +	clocks->rcdev.ops = &r9a06g032_reset_ops;
> +	clocks->rcdev.of_node = np;
> +	clocks->rcdev.of_reset_n_cells = 1;

Don't set of_reset_n_cells, as of_xlate isn't set either.

fwnode_reset_n_cells will be set to 1 by default in
reset_controller_register().

> +	clocks->rcdev.nr_resets = ARRAY_SIZE(r9a06g032_resets);
> +	error =  devm_reset_controller_register(dev, &clocks->rcdev);
                ^
Superfluous whitespace.

> +	if (error)
> +		return error;
> +
>  	return 0;

Could be simplified to just:

	return devm_reset_controller_register(dev, &clocks->rcdev);


regards
Philipp

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells
  2026-11-20  9:51     ` Philipp Zabel
@ 2026-11-20 11:11       ` Wolfram Sang
  0 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20 11:11 UTC (permalink / raw)
  To: Philipp Zabel
  Cc: khendry, Geert Uytterhoeven, Stephen Boyd, Brian Masney,
	Jerome Brunet, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Magnus Damm, Fabrizio Castro, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev


> > > +#define R9A06G032_RST_TS		1
> > > +#define R9A06G032_RST_MIIC		2
> > 
> > I didn't find any listing of the resets in the RZN1 docs, so coming up
> > with arbitrary numbers as we need them seems okay to me.
> 
> Why aren't we starting at 0?

I wondered as well but clocks are also starting from 1, so we could
argue with consistency.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
  2026-11-20  9:30   ` Wolfram Sang
  2026-11-20 10:00   ` Philipp Zabel
@ 2026-11-20 11:47   ` Wolfram Sang
  2026-11-20 23:25   ` kernel test robot
  3 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20 11:47 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev


>  struct r9a06g032_priv {
>  	struct clk_onecell_data data;
>  	spinlock_t lock; /* protects concurrent access to gates */

Build error :( No addition of 'rcdev' to priv data!


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets
  2026-11-19 17:57 ` [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets Kyle Hendry via B4 Relay
@ 2026-11-20 11:49   ` Wolfram Sang
  0 siblings, 0 replies; 18+ messages in thread
From: Wolfram Sang @ 2026-11-20 11:49 UTC (permalink / raw)
  To: khendry
  Cc: Geert Uytterhoeven, Stephen Boyd, Brian Masney, Jerome Brunet,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
	Fabrizio Castro, Philipp Zabel, Clément Léger,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lad Prabhakar, Andrew Lunn, Heiner Kallweit,
	Russell King, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, netdev

On Thu, Nov 19, 2026 at 09:57:46AM -0800, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
> 
> On the rzn1, there are two resets for the miic. Add documentation for them.
> 
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>

I will comment on the bindings over the weekend.

For further testing on real HW, I will wait for v2.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
  2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
                     ` (2 preceding siblings ...)
  2026-11-20 11:47   ` Wolfram Sang
@ 2026-11-20 23:25   ` kernel test robot
  3 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2026-11-20 23:25 UTC (permalink / raw)
  To: Kyle Hendry via B4 Relay, Geert Uytterhoeven, Stephen Boyd,
	Brian Masney, Jerome Brunet, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Magnus Damm, Fabrizio Castro, Philipp Zabel,
	Clément Léger, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Lad Prabhakar,
	Heiner Kallweit, Russell King
  Cc: oe-kbuild-all, netdev, linux-renesas-soc, linux-clk, devicetree,
	linux-kernel, Kyle Hendry

Hi Kyle,

kernel test robot noticed the following build errors:

[auto build test ERROR on 662377fd1bb1d7cf4e97d312255fed868f56342d]

url:    https://github.com/intel-lab-lkp/linux/commits/Kyle-Hendry-via-B4-Relay/dt-bindings-clock-r9a06g032-sysctrl-Document-reset-cells/20261119-095743
base:   662377fd1bb1d7cf4e97d312255fed868f56342d
patch link:    https://lore.kernel.org/r/20261119-rzn1-miic-resets-v1-2-feee2bb28bb4%40reliablecontrols.com
patch subject: [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller
config: arm-shmobile_defconfig (https://download.01.org/0day-ci/archive/20261121/202611210721.sFAijXHV-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261121/202611210721.sFAijXHV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611210721.sFAijXHV-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/container_of.h:5,
                    from include/linux/kernel.h:22,
                    from include/linux/clk.h:13,
                    from drivers/clk/renesas/r9a06g032-clocks.c:10:
   drivers/clk/renesas/r9a06g032-clocks.c: In function 'r9a06g032_reset_set':
>> include/linux/container_of.h:8:47: error: 'struct r9a06g032_priv' has no member named 'rcdev'
       8 | #define typeof_member(T, m)     typeof(((T*)0)->m)
         |                                               ^~
   include/linux/build_bug.h:80:56: note: in definition of macro '__static_assert'
      80 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |         ^~~~~~~~~~~~~
   include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                       ^~~~~~~~~~~
   include/linux/container_of.h:20:43: note: in expansion of macro 'typeof_member'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                                           ^~~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1322:39: note: in expansion of macro 'rcdev_to_priv'
    1322 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
>> include/linux/compiler_types.h:610:27: error: expression in static assertion is not an integer
     610 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:80:56: note: in definition of macro '__static_assert'
      80 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |         ^~~~~~~~~~~~~
   include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                       ^~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1322:39: note: in expansion of macro 'rcdev_to_priv'
    1322 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
   In file included from include/uapi/linux/posix_types.h:5,
                    from include/uapi/linux/types.h:14,
                    from include/linux/types.h:5,
                    from include/linux/kasan-checks.h:5,
                    from include/asm-generic/rwonce.h:26,
                    from ./arch/arm/include/generated/asm/rwonce.h:1,
                    from include/linux/compiler.h:391,
                    from include/linux/err.h:5,
                    from include/linux/clk.h:12:
>> include/linux/stddef.h:16:33: error: 'struct r9a06g032_priv' has no member named 'rcdev'
      16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
         |                                 ^~~~~~~~~~~~~~~~~~
   include/linux/container_of.h:23:34: note: in expansion of macro 'offsetof'
      23 |         (type *)((void *)(ptr) - offsetof(type, member)); })
         |                                  ^~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1322:39: note: in expansion of macro 'rcdev_to_priv'
    1322 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c: In function 'r9a06g032_reset_status':
>> include/linux/container_of.h:8:47: error: 'struct r9a06g032_priv' has no member named 'rcdev'
       8 | #define typeof_member(T, m)     typeof(((T*)0)->m)
         |                                               ^~
   include/linux/build_bug.h:80:56: note: in definition of macro '__static_assert'
      80 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |         ^~~~~~~~~~~~~
   include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                       ^~~~~~~~~~~
   include/linux/container_of.h:20:43: note: in expansion of macro 'typeof_member'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                                           ^~~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1354:39: note: in expansion of macro 'rcdev_to_priv'
    1354 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
>> include/linux/compiler_types.h:610:27: error: expression in static assertion is not an integer
     610 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:80:56: note: in definition of macro '__static_assert'
      80 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |         ^~~~~~~~~~~~~
   include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
      20 |         static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
         |                       ^~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1354:39: note: in expansion of macro 'rcdev_to_priv'
    1354 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
>> include/linux/stddef.h:16:33: error: 'struct r9a06g032_priv' has no member named 'rcdev'
      16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
         |                                 ^~~~~~~~~~~~~~~~~~
   include/linux/container_of.h:23:34: note: in expansion of macro 'offsetof'
      23 |         (type *)((void *)(ptr) - offsetof(type, member)); })
         |                                  ^~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1317:33: note: in expansion of macro 'container_of'
    1317 | #define rcdev_to_priv(x)        container_of(x, struct r9a06g032_priv, rcdev)
         |                                 ^~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c:1354:39: note: in expansion of macro 'rcdev_to_priv'
    1354 |         struct r9a06g032_priv *priv = rcdev_to_priv(rcdev);
         |                                       ^~~~~~~~~~~~~
   drivers/clk/renesas/r9a06g032-clocks.c: In function 'r9a06g032_clocks_probe':
>> drivers/clk/renesas/r9a06g032-clocks.c:1463:15: error: 'struct r9a06g032_priv' has no member named 'rcdev'
    1463 |         clocks->rcdev.ops = &r9a06g032_reset_ops;
         |               ^~
   drivers/clk/renesas/r9a06g032-clocks.c:1464:15: error: 'struct r9a06g032_priv' has no member named 'rcdev'
    1464 |         clocks->rcdev.of_node = np;
         |               ^~
   drivers/clk/renesas/r9a06g032-clocks.c:1465:15: error: 'struct r9a06g032_priv' has no member named 'rcdev'
    1465 |         clocks->rcdev.of_reset_n_cells = 1;
         |               ^~
   drivers/clk/renesas/r9a06g032-clocks.c:1466:15: error: 'struct r9a06g032_priv' has no member named 'rcdev'
    1466 |         clocks->rcdev.nr_resets = ARRAY_SIZE(r9a06g032_resets);
         |               ^~
   drivers/clk/renesas/r9a06g032-clocks.c:1467:61: error: 'struct r9a06g032_priv' has no member named 'rcdev'
    1467 |         error =  devm_reset_controller_register(dev, &clocks->rcdev);
         |                                                             ^~


vim +8 include/linux/container_of.h

d2a8ebbf8192b84 Andy Shevchenko 2021-11-08  4  
d2a8ebbf8192b84 Andy Shevchenko 2021-11-08 @5  #include <linux/build_bug.h>
2b8e35337605ca5 Andy Shevchenko 2023-01-30  6  #include <linux/stddef.h>
d2a8ebbf8192b84 Andy Shevchenko 2021-11-08  7  
d2a8ebbf8192b84 Andy Shevchenko 2021-11-08 @8  #define typeof_member(T, m)	typeof(((T*)0)->m)
d2a8ebbf8192b84 Andy Shevchenko 2021-11-08  9  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2026-11-20 23:26 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
2026-11-20  9:23   ` Wolfram Sang
2026-11-20  9:51     ` Philipp Zabel
2026-11-20 11:11       ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
2026-11-20  9:30   ` Wolfram Sang
2026-11-20 10:00   ` Philipp Zabel
2026-11-20 11:47   ` Wolfram Sang
2026-11-20 23:25   ` kernel test robot
2026-11-19 17:57 ` [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node Kyle Hendry via B4 Relay
2026-11-20  9:32   ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets Kyle Hendry via B4 Relay
2026-11-20 11:49   ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure Kyle Hendry via B4 Relay
2026-11-19 17:57 ` [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter Kyle Hendry via B4 Relay
2026-11-20  9:34   ` Wolfram Sang
2026-11-19 22:02 ` [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for " Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox