netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v2] net: bcmgenet: reject undersized RX classification rule buffers
@ 2026-11-22  8:22 Artemii Mashanov
  0 siblings, 0 replies; only message in thread
From: Artemii Mashanov @ 2026-11-22  8:22 UTC (permalink / raw)
  To: netdev
  Cc: Doug Berger, Florian Fainelli, Nicolai Buchwitz,
	Broadcom internal kernel review list, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni

The rule list can grow between ETHTOOL_GRXCLSRLCNT and
ETHTOOL_GRXCLSRLALL. If the supplied array is too small,
bcmgenet_get_rxnfc() currently reports success with only the rule
locations that fit.

Return -EMSGSIZE when another location cannot fit so callers can
detect an incomplete dump. On success, continue reporting the number
of locations copied.

Signed-off-by: Artemii Mashanov <ralerrdirsardx@gmail.com>
---
Changes in v2:
  - Retarget to net-next as requested by Nicolai.
  - Clarify the commit message and drop the Fixes and test lines.
  - No code changes.

v1: https://lore.kernel.org/netdev/20261121001550.732679-1-ralerrdirsardx@gmail.com/

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 6545caf..a84c8ce 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1664,7 +1664,7 @@ static int bcmgenet_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
 	struct bcmgenet_priv *priv = netdev_priv(dev);
 	struct bcmgenet_rxnfc_rule *rule;
 	int err = 0;
-	int i = 0;
+	u32 i = 0;
 
 	switch (cmd->cmd) {
 	case ETHTOOL_GRXCLSRLCNT:
@@ -1675,9 +1675,11 @@ static int bcmgenet_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
 		err = bcmgenet_get_flow(dev, cmd, cmd->fs.location);
 		break;
 	case ETHTOOL_GRXCLSRLALL:
-		list_for_each_entry(rule, &priv->rxnfc_list, list)
-			if (i < cmd->rule_cnt)
-				rule_locs[i++] = rule->fs.location;
+		list_for_each_entry(rule, &priv->rxnfc_list, list) {
+			if (i == cmd->rule_cnt)
+				return -EMSGSIZE;
+			rule_locs[i++] = rule->fs.location;
+		}
 		cmd->rule_cnt = i;
 		cmd->data = MAX_NUM_OF_FS_RULES;
 		break;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-22  9:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22  8:22 [PATCH net-next v2] net: bcmgenet: reject undersized RX classification rule buffers Artemii Mashanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).