* [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY
@ 2026-05-11 18:18 Selvamani Rajagopal
2026-05-11 19:15 ` Andrew Lunn
2026-05-11 19:37 ` Rob Herring (Arm)
0 siblings, 2 replies; 3+ messages in thread
From: Selvamani Rajagopal @ 2026-05-11 18:18 UTC (permalink / raw)
To: Piergiorgio Beruto, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Add YAML device tree binding for the onsemi S2500
IEEE 802.3cg compliant Ethernet transceiver devices.
Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
---
.../devicetree/bindings/net/onnn,s2500.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml
diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
new file mode 100644
index 000000000..94a73b5f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/onnn,s2500.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: onsemi S2500 10BASE-T1S MACPHY Ethernet Controllers
+
+maintainers:
+ - Piergiorgio Beruto <Pier.Beruto@onsemi.com>
+ - Selva Rajagopal <Selvamani.Rajagopal@onsemi.com>
+
+description:
+ The S2500 combines a Media Access Controller (MAC) and an
+ Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
+ Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
+ compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
+ transceiver integrated into the S2500. The communication between
+ the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
+ MACPHY Serial Interface (TC6).
+
+ Specifications about the S2500 can be found at:
+ https://www.onsemi.com/download/data-sheet/pdf/t30hm1ts2500-d.pdf
+
+allOf:
+ - $ref: /schemas/net/ethernet-controller.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: onnn,s2500
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description:
+ Interrupt from MAC-PHY asserted in the event of Receive Chunks
+ Available, Transmit Chunk Credits Available and Extended Status
+ Event.
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet@0 {
+ compatible = "onnn,s2500";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <ð0_pins>;
+ interrupt-parent = <&gpio>;
+ interrupts = <25 2>;
+ };
+ };
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY
2026-05-11 18:18 [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY Selvamani Rajagopal
@ 2026-05-11 19:15 ` Andrew Lunn
2026-05-11 19:37 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-05-11 19:15 UTC (permalink / raw)
To: Selvamani Rajagopal
Cc: Piergiorgio Beruto, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet@0 {
> + compatible = "onnn,s2500";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <ð0_pins>;
> + interrupt-parent = <&gpio>;
> + interrupts = <25 2>;
IRQ_TYPE_EDGE_FALLING
But is edge correct? Should it be level?
And i hope this illustrates why you should use the defines.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY
2026-05-11 18:18 [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY Selvamani Rajagopal
2026-05-11 19:15 ` Andrew Lunn
@ 2026-05-11 19:37 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-05-11 19:37 UTC (permalink / raw)
To: Selvamani Rajagopal
Cc: Piergiorgio Beruto, conor+dt, kuba, devicetree, andrew+netdev,
edumazet, krzk+dt, linux-kernel, netdev, pabeni, davem
On Mon, 11 May 2026 18:18:55 +0000, Selvamani Rajagopal wrote:
> Add YAML device tree binding for the onsemi S2500
> IEEE 802.3cg compliant Ethernet transceiver devices.
>
> Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> ---
> .../devicetree/bindings/net/onnn,s2500.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/onnn,s2500.yaml:22:49: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/onnn,s2500.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/net/onnn,s2500.yaml:22:49: mapping values are not allowed here
make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/onnn,s2500.example.dts'
Documentation/devicetree/bindings/net/onnn,s2500.yaml:22:49: mapping values are not allowed here
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/onnn,s2500.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1639: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/CY8PR02MB924920C8825C7AE5D22EFA4483382@CY8PR02MB9249.namprd02.prod.outlook.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-11 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11 18:18 [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY Selvamani Rajagopal
2026-05-11 19:15 ` Andrew Lunn
2026-05-11 19:37 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox