From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Nicolai Buchwitz <nb@tipi-net.de>, Andrew Lunn <andrew@lunn.ch>
Cc: "James Clark" <jjc@jclark.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Doug Berger" <opendmb@gmail.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Russell King" <linux@armlinux.org.uk>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Miroslav Lichvar" <mlichvar@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] net: mdio: bcm-unimac: implement timestamped MDIO writes
Date: Thu, 15 Oct 2026 15:12:56 -0700 [thread overview]
Message-ID: <2279ba71-009f-429b-a27e-dc72ab11cfbc@broadcom.com> (raw)
In-Reply-To: <6b5ff0aee5db9bba10828d2f949c9d67@tipi-net.de>
On 10/12/26 06:21, Nicolai Buchwitz wrote:
> Hi Andrew
>
> On 12.10.2026 13:51, Andrew Lunn wrote:
>
>> [...]
>
>>> I've put together 3 patches, which do the clock plumbing:
>>> https://github.com/nbuchwitz/linux/commits/devel/bcm2711-gisb-clk/
>>
>> It would be nice to extend this and set the divider based on this to
>> give 2.5Mhz, as required by 802.3, as the default. Allow boards to
>> override this using the clock-frequency property.
Regarding the choice of the GISB clock to feed it into the MDIO clock
input, that's something for Raspberry Pi to comment on because I vividly
remember we did something different for 7211 and used a 250MHz clock in
the interest of being identical to the other STB chips. Your changes do
look correct however.
>
> Sure, as a net-next follow-up once James's clock lookup is in, plus a
> binding tweak since it currently promises hardware defaults?
>
> Only BCM2711 would notice for now, 10 MHz down to 2.5. Both Pi PHYs do
> 12.5 MHz and the slower bus mainly hurts the PTP path, so I'd set
> clock-frequency = <10000000> in bcm2711-rpi.dtsi to keep what the
> boards do today. Florian, ok?
Works for me if it gets us what James want as well, thanks Nicolai!
--
Florian
next prev parent reply other threads:[~2026-10-15 22:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:35 [PATCH net-next 0/5] net: mdio: add timestamped MDIO writes for PHY gettimex64 James Clark
2026-10-09 14:35 ` [PATCH net-next 1/5] net: mdio: add timestamped write operation James Clark
2026-10-10 15:10 ` netdev-bot+sashiko
2026-10-11 14:03 ` Andrew Lunn
2026-10-11 14:33 ` James Clark
2026-10-09 14:35 ` [PATCH net-next 2/5] net: phy: broadcom: use timestamped MDIO writes in gettimex64 James Clark
2026-10-10 15:10 ` netdev-bot+sashiko
2026-10-09 14:35 ` [PATCH net-next 3/5] ptp: add functions to adjust system timestamps James Clark
2026-10-10 15:10 ` netdev-bot+sashiko
2026-10-09 14:35 ` [PATCH net-next 4/5] net: macb: implement timestamped MDIO writes James Clark
2026-10-10 15:10 ` netdev-bot+sashiko
2026-10-11 9:23 ` Théo Lebrun
2026-10-11 10:02 ` Théo Lebrun
2026-10-11 13:01 ` James Clark
2026-10-15 15:52 ` Théo Lebrun
2026-10-15 16:02 ` Andrew Lunn
2026-10-11 21:10 ` Andrew Lunn
2026-10-09 14:35 ` [PATCH net-next 5/5] net: mdio: bcm-unimac: " James Clark
2026-10-09 16:04 ` Florian Fainelli
2026-10-10 1:25 ` James Clark
2026-10-10 15:18 ` Nicolai Buchwitz
2026-10-11 7:20 ` James Clark
2026-10-11 13:22 ` Nicolai Buchwitz
2026-10-12 0:54 ` James Clark
2026-10-12 13:18 ` Nicolai Buchwitz
2026-10-12 11:51 ` Andrew Lunn
2026-10-12 13:21 ` Nicolai Buchwitz
2026-10-15 22:12 ` Florian Fainelli [this message]
2026-10-10 15:11 ` netdev-bot+sashiko
2026-10-12 12:03 ` Andrew Lunn
2026-10-10 4:55 ` [PATCH net-next 0/5] net: mdio: add timestamped MDIO writes for PHY gettimex64 James Clark
2026-10-11 13:50 ` Andrew Lunn
2026-10-11 14:00 ` James Clark
2026-10-11 18:07 ` Nicolai Buchwitz
2026-10-12 13:18 ` Andrew Lunn
2026-10-12 13:20 ` Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2279ba71-009f-429b-a27e-dc72ab11cfbc@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jjc@jclark.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mlichvar@redhat.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@kernel.org \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox