From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>,
Bhaskar Chowdhury <unixbhaskar@gmail.com>,
Julian Calaby <julian.calaby@gmail.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
zhengbin13@huawei.com, baijiaju1990@gmail.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty
Date: Tue, 5 Jan 2021 12:09:19 -0600 [thread overview]
Message-ID: <23353e52-8a50-2024-e5b0-591d4e2f720e@lwfinger.net> (raw)
In-Reply-To: <d6ee8f44f9ca285f17bdec972bcd0abb89fe64d6.camel@perches.com>
On 1/5/21 5:55 AM, Joe Perches wrote:
> On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
>> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
>>> Hi Bhaskar,
> []
>>> and your change is just making this comment worse.
>> really??? Not sure about it.
>
> I agree with Julian. I'm fairly sure it's worse.
> The change you suggest doesn't parse well and is extremely odd.
> If you _really_ want to just change this use (and the others),
> I repeat his suggestion of "by default".
I agree with Julian and Joe. Your suggested change makes it worse!
To match ALL previous commits/patches for these drivers, the subject should be
"rtlwifi: <driver_name>: Fix description of usage of own bit in descriptor"
For all drivers, that comment should be written as:
/* By default, a beacon packet will only use the first
* descriptor and the own bit may not be cleared by the hardware
*/
Larry
next prev parent reply other threads:[~2021-01-05 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 10:17 [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty Bhaskar Chowdhury
2021-01-05 10:33 ` Julian Calaby
2021-01-05 10:48 ` Bhaskar Chowdhury
2021-01-05 11:24 ` Julian Calaby
2021-01-05 11:41 ` Bhaskar Chowdhury
2021-01-05 11:55 ` Joe Perches
2021-01-05 18:09 ` Larry Finger [this message]
2021-01-05 17:02 ` Randy Dunlap
2021-01-06 13:18 ` Bhaskar Chowdhury
2021-01-06 16:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23353e52-8a50-2024-e5b0-591d4e2f720e@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=baijiaju1990@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=julian.calaby@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=unixbhaskar@gmail.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox