From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: pkshih@realtek.com, kvalo@codeaurora.org, davem@davemloft.net,
kuba@kernel.org, Larry.Finger@lwfinger.net,
zhengbin13@huawei.com, baijiaju1990@gmail.com,
christophe.jaillet@wanadoo.fr, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty
Date: Wed, 6 Jan 2021 18:48:39 +0530 [thread overview]
Message-ID: <X/W4r1rmMCnKQAQZ@Gentoo> (raw)
In-Reply-To: <35a634c1-3672-b757-101e-9b8f3c0163a7@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On 09:02 Tue 05 Jan 2021, Randy Dunlap wrote:
>On 1/5/21 2:17 AM, Bhaskar Chowdhury wrote:
>> s/defautly/de-faulty/p
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> index c948dafa0c80..7d02d8abb4eb 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> @@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
>> u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
>>
>> /*beacon packet will only use the first
>> - *descriptor defautly,and the own may not
>> + *descriptor de-faulty,and the own may not
>> *be cleared by the hardware
>> */
>> if (own)
>> --
>
>Yes, I agree with "by default". I don't know what "the own"
>means.
>
>Also, there should be a space after each beginning "*.
>
>I saw another patch where the comment block began with /**,
>which should mean "begin kernel-doc comment block", but it's
>not kernel-doc, so that /** should be changed to just "/*".
>
>
Good point Randy, there were several driver file witch have "defautly" in it
and I tried to correct that.Only that spell made it a "de-faulty" as dic
suggested . But I think it should be "by default" as you said.
The comment beginning part , let me hunt down that and fix it as you mentioned
the way it should be.
Thanks Randy.
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-06 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 10:17 [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty Bhaskar Chowdhury
2021-01-05 10:33 ` Julian Calaby
2021-01-05 10:48 ` Bhaskar Chowdhury
2021-01-05 11:24 ` Julian Calaby
2021-01-05 11:41 ` Bhaskar Chowdhury
2021-01-05 11:55 ` Joe Perches
2021-01-05 18:09 ` Larry Finger
2021-01-05 17:02 ` Randy Dunlap
2021-01-06 13:18 ` Bhaskar Chowdhury [this message]
2021-01-06 16:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/W4r1rmMCnKQAQZ@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=baijiaju1990@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rdunlap@infradead.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox