Re: [PATCH net-next v8 3/7] r8169: add support for phylink

[Andrew Lunn <andrew@lunn.ch>]

> How would you prefer I handle this limitation?

In ksettings_set return -EOPNOTUSPP for what you don't support.  And
in mac_link_up add a comment.

Also, please test that it does the advertisement settings correctly,
for the four different modes:

ethtool -A|--pause devname [autoneg on|off] [rx on|off] [tx on|off]

with autoneg on, but:

1) rx on, tx off
2) rx on, tx on
3) ...
4) ...

Since phylink/phylib is doing this, it probably does.

Testing the MAC actually does the correct thing is more difficult, you
need to slow down either the local MAC or the LP MAC to cause buffers
to fill and pause actions to be taken.

You also have the issue of how is the hardware getting the results of
the autoneg? If it is directly performing MDIO transactions, that can
go wrong on PHYs with pages, since Linux could of swapped page.

   Andrew