* [PATCH] net: hns: add function declarations in hns_dsaf_mac.h
@ 2016-09-18 9:11 Baoyou Xie
2016-09-18 20:37 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-18 9:11 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, yankejian, huangdaode,
lipeng321
Cc: netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 2 warnings when building kernel with W=1:
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes]
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes]
In fact, these two functions are not declared in any file, but should
be declared in a header file, thus can be recognized in other file.
So this patch adds the declarations into
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
index 4cbdf14..31f6505 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
@@ -462,4 +462,6 @@ int hns_cpld_led_set_id(struct hns_mac_cb *mac_cb,
enum hnae_led_state status);
void hns_mac_set_promisc(struct hns_mac_cb *mac_cb, u8 en);
+void hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset);
+void hns_dsaf_roce_srst(struct dsaf_device *dsaf_dev, bool dereset);
#endif /* _HNS_DSAF_MAC_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h
2016-09-18 9:11 [PATCH] net: hns: add function declarations in hns_dsaf_mac.h Baoyou Xie
@ 2016-09-18 20:37 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-18 20:37 UTC (permalink / raw)
To: Baoyou Xie
Cc: yisen.zhuang, salil.mehta, davem, yankejian, huangdaode,
lipeng321, netdev, linux-kernel, xie.baoyou
On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes]
>
> In fact, these two functions are not declared in any file, but should
> be declared in a header file, thus can be recognized in other file.
>
> So this patch adds the declarations into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Why can't these be declared static?
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-18 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-18 9:11 [PATCH] net: hns: add function declarations in hns_dsaf_mac.h Baoyou Xie
2016-09-18 20:37 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox