From: David Howells <dhowells@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] udp: Add tracepoints to monitor skbs going in and out of a UDP socket
Date: Thu, 04 Oct 2018 17:54:33 +0100 [thread overview]
Message-ID: <25668.1538672073@warthog.procyon.org.uk> (raw)
In-Reply-To: <f4d5ec71-b09a-84fa-599e-d0482cdb77b7@gmail.com>
David Ahern <dsahern@gmail.com> wrote:
> These do not add any real value. You are only dumping the skb address,
Not in and of themselves, no - but in combination with tracepoints elsewhere,
where you can use the skb address as a key to follow the lifetime of a
particular skb.
> and you can get the same effect with a probe on the function and dumping
> the value of the register with the skb argument.
Installing a probe requires various preconditions, including your kernel not
being locked down and having the source around AIUI.
Anyway, I've no especially strong feelings about this patch - it's been useful
for me and it might be useful to others.
David
next prev parent reply other threads:[~2018-10-04 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:30 [PATCH net-next] udp: Add tracepoints to monitor skbs going in and out of a UDP socket David Howells
2018-10-04 16:36 ` David Ahern
2018-10-04 16:54 ` David Howells [this message]
2018-10-04 17:19 ` Alexei Starovoitov
2018-10-04 23:24 ` David Howells
2018-10-05 2:03 ` Alexei Starovoitov
2018-10-05 6:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25668.1538672073@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dsahern@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox