From: Max Staudt <max@enpas.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] can: can327: fix snprintf() limit in can327_handle_prompt()
Date: Thu, 14 Nov 2024 19:11:25 +0900 [thread overview]
Message-ID: <26302002-0b96-49c1-bee4-648aa18ae7fb@enpas.org> (raw)
In-Reply-To: <033f74e6-2706-439a-9c02-158df11a3192@stanley.mountain>
On 11/14/24 18:29, Dan Carpenter wrote:
> To be honest, I was afraid that someone was going to suggest using on of the
> helper functions that dumps hex. (I don't remember then names of them so that's
> why I didn't do that).
If you can think of a neat, clearer replacement for sprintf() in this
case, that'd be nice. I guess I didn't find one at the time when I wrote
the driver (or I didn't look hard enough).
Suggestions welcome!
Max
next prev parent reply other threads:[~2024-11-14 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 9:03 [PATCH net] can: can327: fix snprintf() limit in can327_handle_prompt() Dan Carpenter
2024-11-14 9:19 ` Max Staudt
2024-11-14 9:26 ` Dan Carpenter
2024-11-14 9:29 ` Dan Carpenter
2024-11-14 10:11 ` Max Staudt [this message]
2024-11-14 9:34 ` Vincent Mailhol
2024-11-14 9:57 ` Dan Carpenter
2024-11-14 12:35 ` Vincent Mailhol
2024-11-14 13:34 ` Marc Kleine-Budde
2024-11-14 14:54 ` Vincent Mailhol
2024-11-14 15:08 ` Dan Carpenter
2024-11-14 15:24 ` Vincent Mailhol
2024-11-14 15:42 ` Dan Carpenter
2024-11-19 0:48 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26302002-0b96-49c1-bee4-648aa18ae7fb@enpas.org \
--to=max@enpas.org \
--cc=andrew+netdev@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox